Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing spaces in Graphviz configure options #19687

Merged

Conversation

jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Jan 23, 2024

currently, easyconfigs do the following:

configopts += '--with-javalibdir=$JAVA_HOME/lib'
configopts += '--with-expatincludedir=$EBROOTEXPAT/include --with-expatlibdir=$EBROOTEXPAT/lib'
configopts += '--with-zincludedir=$EBROOTZLIB/include --with-zlibdir=$EBROOTZLIB/lib'

since there are no spaces at the end or start of the strings, these just get glued together into options like --with-expatlibdir=$EBROOTEXPAT/lib--with-zincludedir=$EBROOTZLIB/include

(created using eb --new-pr)

@jfgrimm jfgrimm added this to the release after 4.9.0 milestone Jan 23, 2024
@verdurin
Copy link
Member

Test report by @verdurin
FAILED
Build succeeded for 11 out of 14 (3 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/c61ff2b356aee6aaba83651bafa06bb1 for a full test report.

@jfgrimm
Copy link
Member Author

jfgrimm commented Jan 23, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19687 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19687 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12694

Test results coming soon (I hope)...

- notification for comment with ID 1906523842 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/61e3b7091e11b176d9d3c801adcb29bd for a full test report.

@verdurin
Copy link
Member

Hmm, local build failure was with libGLU:

== 2024-01-23 15:54:24,857 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/base/exceptions.py:126 in __init__): cmd " ./configure --prefix=/eb/maint/software/libGLU/9.0.3-GCCcore-12.3.0 " exited with exit code 127 and output:
/bin/bash: ./configure: No such file or directory
 (at easybuild/tools/run.py:682 in parse_cmd_output)

Could be yet another CentOS 7 thing?

@jfgrimm
Copy link
Member Author

jfgrimm commented Jan 24, 2024

@boegelbot: please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19687 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19687 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3457

Test results coming soon (I hope)...

- notification for comment with ID 1907966390 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (3 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/f6b2de4380f9d084720a1c323f1ae44b for a full test report.

@jfgrimm
Copy link
Member Author

jfgrimm commented Jan 24, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 15 out of 15 (3 easyconfigs in total)
gpu07.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, 2 x NVIDIA NVIDIA A40, 535.86.10, Python 3.6.8
See https://gist.github.com/jfgrimm/09ca7d83fa6458acdd8a93cdcde57880 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/3bf721508f405b5cfc7fd5a44ab60666 for a full test report.

Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

Going in, thanks @jfgrimm!

@verdurin verdurin merged commit 84870f6 into easybuilders:develop Jan 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants