Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for jupyter_core extension in jupyter-server to set jupyter path by $EB_ENV_JUPYTER_ROOT #19737

Conversation

appolloford
Copy link
Contributor

@appolloford appolloford commented Jan 27, 2024

(created using eb --new-pr) Issue: #19097

  • GCCcore-12.2.0
  • GCCcore-12.3.0

@boegelbot
Copy link
Collaborator

@appolloford: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/7681453271
Output from first failing test suite run:

FAIL: test_pr_sha256_checksums (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure changed easyconfigs have SHA256 checksums in place.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1035, in test_pr_sha256_checksums
    self.assertTrue(len(checksum_issues) == 0, "No checksum issues:\n%s" % '\n'.join(checksum_issues))
AssertionError: False is not true : No checksum issues:
Checksums missing for one or more sources/patches of extension jupyter_core in jupyter-server-2.7.0-GCCcore-12.2.0.eb: found 1 sources + 1 patches vs 1 checksums

----------------------------------------------------------------------
Ran 19027 tests in 729.448s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@appolloford appolloford marked this pull request as draft January 28, 2024 10:27
@boegelbot

This comment was marked as resolved.

@appolloford appolloford marked this pull request as ready for review January 31, 2024 23:18
@appolloford
Copy link
Contributor Author

@Micket

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the release after 4.9.0 milestone Mar 20, 2024
@Micket Micket added the bug fix label Mar 20, 2024
@Micket
Copy link
Contributor

Micket commented Mar 20, 2024

Test report by @Micket
SUCCESS
Build succeeded for 19 out of 19 (10 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/e1cfdfc3d717516cd1a2d61bd65ef671 for a full test report.

@Micket
Copy link
Contributor

Micket commented Mar 22, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=19737 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19737 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13185

Test results coming soon (I hope)...

- notification for comment with ID 2015486200 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c8fbfa7c4afbbae63c28854c15d041e2 for a full test report.

@Micket
Copy link
Contributor

Micket commented Mar 26, 2024

Test report by @Micket
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
vera-icelake-build - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/Micket/9daa5642452c09eba6186d5a168f9c0b for a full test report.

@Micket
Copy link
Contributor

Micket commented Mar 26, 2024

Test report by @Micket
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/adda142d631789189aca29e77daf044d for a full test report.

@Micket
Copy link
Contributor

Micket commented Mar 26, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19737 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19737 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3864

Test results coming soon (I hope)...

- notification for comment with ID 2020875546 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 12 out of 12 (10 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/75c9442f320642529aa41b908203658c for a full test report.

@Micket
Copy link
Contributor

Micket commented Mar 26, 2024

Going in, thanks @appolloford!

@Micket Micket merged commit 5ff7393 into easybuilders:develop Mar 26, 2024
9 checks passed
@Micket
Copy link
Contributor

Micket commented Mar 26, 2024

Confirmed that the bug with saving settings in jupyterlab works!

@Micket
Copy link
Contributor

Micket commented Mar 26, 2024

Test report by @Micket
SUCCESS
Build succeeded for 11 out of 11 (10 easyconfigs in total)
alvis-icelake-build - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/Micket/2ef5034e760dc3d1e8566ea787e7299e for a full test report.

@Micket
Copy link
Contributor

Micket commented Mar 26, 2024

Test report by @Micket
SUCCESS
Build succeeded for 11 out of 11 (10 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/7e858c569e42dc70fd6ec56d4b0cecdb for a full test report.

@boegel boegel changed the title Add patch for jupyter_core to set jupyter path by EB_ENV_JUPYTER_ROOT Add patch for jupyter_core to set jupyter path by $EB_ENV_JUPYTER_ROOT Mar 27, 2024
@boegel boegel changed the title Add patch for jupyter_core to set jupyter path by $EB_ENV_JUPYTER_ROOT Add patch for jupyter_core to set jupyter path by $EB_ENV_JUPYTER_ROOT Mar 27, 2024
@boegel boegel changed the title Add patch for jupyter_core to set jupyter path by $EB_ENV_JUPYTER_ROOT Add patch for jupyter_core extension in jupyter-server to set jupyter path by $EB_ENV_JUPYTER_ROOT Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants