Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{astro,lib}[foss/2023b] DP3-6.0, WSClean 3.4 and deps #19840

Merged
merged 26 commits into from Mar 11, 2024
Merged

{astro,lib}[foss/2023b] DP3-6.0, WSClean 3.4 and deps #19840

merged 26 commits into from Mar 11, 2024

Conversation

t1mk1k
Copy link

@t1mk1k t1mk1k commented Feb 13, 2024

Upgrade DP3 and WSClean to foss-2023b toolchain

@casparvl
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19840 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19840 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12877

Test results coming soon (I hope)...

- notification for comment with ID 1941713496 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 17 out of 17 (17 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4ece9c79fc4041d5340ef394dc0691f1 for a full test report.

@casparvl
Copy link
Contributor

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19840 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19840 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3610

Test results coming soon (I hope)...

- notification for comment with ID 1942855566 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 18 out of 18 (16 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/d2bff82713a84b1bc2fc966829d8bb80 for a full test report.

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 0 out of 0 (16 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/ad7b4e9c2f8d7d1970c955767b725e28 for a full test report.

casparvl
casparvl reviewed Feb 14, 2024
View reviewed changes
easybuild/easyconfigs/a/arpack-ng/arpack-ng-3.9.0-foss-2023b.eb Outdated

builddependencies = [
('Autotools', '20220317'),
('pkg-config', '0.29.2'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace with pkgconf-2.0.3? We're trying to phase out using pkg-config as it has been unmaintained for a long time #14390

(likewise for other occurrences of this dep in this PR)

casparvl
casparvl reviewed Feb 14, 2024
View reviewed changes
easybuild/easyconfigs/p/pkg-config/pkg-config-0.29.2-GCCcore-13.2.0.eb Outdated
@@ -0,0 +1,35 @@
easyblock = 'ConfigureMake'

name = 'pkg-config'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This EasyConfig can be removed if the build deps are replaced with pkgconf-2.0.3

@boegel boegel mentioned this pull request Feb 20, 2024
Merged
@easybuilders easybuilders deleted a comment from boegelbot Feb 20, 2024
@easybuilders easybuilders deleted a comment from boegelbot Feb 20, 2024
@easybuilders easybuilders deleted a comment from boegelbot Feb 20, 2024
@easybuilders easybuilders deleted a comment from boegelbot Feb 20, 2024
@casparvl
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19840 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19840 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13065

Test results coming soon (I hope)...

- notification for comment with ID 1988449519 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19840 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19840 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3743

Test results coming soon (I hope)...

- notification for comment with ID 1988462871 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 16 out of 16 (16 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/23745557e2e7b833054ad43edd9c9cfd for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 16 out of 16 (16 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/da85cc61948ddf335e65c40bde3b8b1d for a full test report.

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 16 out of 16 (16 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/89225b56e2145af906ec5f304324e2b4 for a full test report.

casparvl
casparvl approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl added this to the release after 4.9.0 milestone Mar 11, 2024
@casparvl casparvl added EESSI Related to EESSI project update labels Mar 11, 2024
@casparvl
Copy link
Contributor

Going in, thanks @t1mk1k!

@casparvl casparvl merged commit 20be2af into easybuilders:develop Mar 11, 2024
9 checks passed
@t1mk1k
Copy link
Author

t1mk1k commented Mar 11, 2024

Great! Thanks for your help @casparvl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casparvl casparvl casparvl approved these changes

Assignees
No one assigned
Labels
EESSI Related to EESSI project update
Projects
None yet
Milestone
4.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t1mk1k @casparvl @boegelbot