-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update loompy builddep - use poetry 1.5.1 to not have a conflict with other modules #20148
Update loompy builddep - use poetry 1.5.1 to not have a conflict with other modules #20148
Conversation
@boegelbot please test @ generoso |
@pavelToman: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2006551624 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2006835027 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm happy to merge this, I don't really understand the issue this would solve. Since poetry is only a build dependency, it will never conflict with other modules, as it won't be loaded at runtime. Using multiple versions as buildtime dependencies is therefore allowed by our CI. Am I misssing something here?
Test report by @casparvl |
I try to solve this problem: #20115 (comment) |
I indeed think it won't solve it, the version of I'll comment in the other ticket, but I'll close this PR as I don't think this is the solution (if needed, we can always reopen again). |
(created using
eb --new-pr
)