Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loompy builddep - use poetry 1.5.1 to not have a conflict with other modules #20148

Conversation

pavelToman
Copy link
Contributor

(created using eb --new-pr)

@pavelToman
Copy link
Contributor Author

@boegelbot please test @ generoso

@pavelToman pavelToman changed the title use poetry 1.5.1 to not have a conflict with other modules Update builddep poetry - use poetry 1.5.1 to not have a conflict with other modules Mar 19, 2024
@pavelToman pavelToman changed the title Update builddep poetry - use poetry 1.5.1 to not have a conflict with other modules Update loompy builddep - use poetry 1.5.1 to not have a conflict with other modules Mar 19, 2024
@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on login1

PR test command 'EB_PR=20148 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20148 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13135

Test results coming soon (I hope)...

- notification for comment with ID 2006551624 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e57a56be8863142967c3a3c886d9f7bd for a full test report.

@pavelToman
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20148 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20148 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3797

Test results coming soon (I hope)...

- notification for comment with ID 2006835027 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/a046dd183d534ca9d43c9180afe5303d for a full test report.

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm happy to merge this, I don't really understand the issue this would solve. Since poetry is only a build dependency, it will never conflict with other modules, as it won't be loaded at runtime. Using multiple versions as buildtime dependencies is therefore allowed by our CI. Am I misssing something here?

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/f353a60b92bd35134469152b2e724ce4 for a full test report.

@pavelToman
Copy link
Contributor Author

While I'm happy to merge this, I don't really understand the issue this would solve. Since poetry is only a build dependency, it will never conflict with other modules, as it won't be loaded at runtime. Using multiple versions as buildtime dependencies is therefore allowed by our CI. Am I misssing something here?

I try to solve this problem: #20115 (comment)
Do you think it will not fix it or is there a better solution?

@casparvl
Copy link
Contributor

I indeed think it won't solve it, the version of poetry used for loompy will not be loaded during the build of #20115 , since it is a build dependency, it is only loaded during build time when building loompy itself.

I'll comment in the other ticket, but I'll close this PR as I don't think this is the solution (if needed, we can always reopen again).

@casparvl casparvl closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants