Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several typos in GlobalArrays 5.8.x configure step #20188

Merged

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Mar 21, 2024

fixes #19845

@Micket Micket added the bug fix label Mar 21, 2024
@Micket Micket added this to the release after 4.9.0 milestone Mar 21, 2024
@Micket
Copy link
Contributor Author

Micket commented Mar 21, 2024

@boegelbot please test @ generoso

@Micket
Copy link
Contributor Author

Micket commented Mar 21, 2024

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/14a2bb0311402e1362dd0c422d183469 for a full test report.

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20188 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20188 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13174

Test results coming soon (I hope)...

- notification for comment with ID 2013651085 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d28070b3be1500ee9072576cfd745cd7 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Mar 21, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20188 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20188 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3834

Test results coming soon (I hope)...

- notification for comment with ID 2013725517 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/7f3826e3fa923851d40f736b857e4cd9 for a full test report.

@casparvl
Copy link
Contributor

Test report by @casparvl
FAILED
Build succeeded for 5 out of 8 (4 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/010e25e916984d0b1465b32493222b5e for a full test report.

@casparvl
Copy link
Contributor

Ignore that, it's a checksum error in the intel toolchain... I'll fix it and retry.

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/c91759ce43971910ac442442df1ca1a5 for a full test report.

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl
Copy link
Contributor

Going in, thanks @Micket!

@casparvl casparvl merged commit e9f35fe into easybuilders:develop Mar 22, 2024
9 checks passed
@Micket Micket deleted the 20240321201703_new_pr_GlobalArrays581 branch March 24, 2024 01:27
@boegel boegel changed the title Fix several typos in GlobalArrays 5.8 configure step Fix several typos in GlobalArrays 5.8.x configure step Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GlobalArrays configopts
3 participants