Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable test that fetches from the web for torchtext extension in PyTorch-bundle v2.1.2 #20484

Merged
merged 2 commits into from
May 13, 2024
Merged

disable test that fetches from the web for torchtext extension in PyTorch-bundle v2.1.2 #20484

merged 2 commits into from
May 13, 2024

Conversation

casparvl
Copy link
Contributor

@casparvl casparvl commented May 6, 2024 •
edited
Loading

(created using eb --new-pr)

I got a timeout on the test_download_glove_vectors test of torchtext since it fetches something from the web (or tries to). The original PR already skipped the test_download_charngram_vectors for the same reason, I guess I just found one that wasn't hit before.

@casparvl casparvl changed the title Disable test that fetches from the web PyTorch-bundle-2.1.2 Disable test that fetches from the web May 6, 2024
@casparvl casparvl changed the title PyTorch-bundle-2.1.2 Disable test that fetches from the web {lib}[GCCcore/12.3.0] PyTorch-bundle-2.1.2 - Disable test that fetches from the web May 6, 2024
@casparvl casparvl added this to the release after 4.9.1 milestone May 6, 2024
@casparvl casparvl marked this pull request as draft May 6, 2024 18:34
@casparvl
Copy link
Contributor Author

casparvl commented May 7, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20484 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20484 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4083

Test results coming soon (I hope)...

- notification for comment with ID 2097924563 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/bd7dc22cd8aa71d905b6ebe3d55c3a60 for a full test report.

@casparvl
Copy link
Contributor Author

casparvl commented May 7, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=20484 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20484 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13420

Test results coming soon (I hope)...

- notification for comment with ID 2098030958 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor Author

casparvl commented May 7, 2024

Test report by @boegelbot FAILED Build succeeded for 0 out of 1 (1 easyconfigs in total) jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18 See https://gist.github.com/boegelbot/bd7dc22cd8aa71d905b6ebe3d55c3a60 for a full test report.

Not sure why this failed. It was still succesful here, though a lot hast changed in that PR after that test. Not sure why it wasn't invoked again, I guess because there were plenty of other (succesful) test reports from other systems by then. I'll retry, see if it's a hickup somehow...

@casparvl
Copy link
Contributor Author

casparvl commented May 7, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/300088cff2df1d4ffc66b60a30dc14d3 for a full test report.

@casparvl
Copy link
Contributor Author

casparvl commented May 7, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20484 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20484 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4086

Test results coming soon (I hope)...

- notification for comment with ID 2098191268 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/18b3124e14f4f70e205a5722874b3979 for a full test report.

@casparvl
Copy link
Contributor Author

casparvl commented May 7, 2024

Test report by @boegelbot FAILED Build succeeded for 0 out of 1 (1 easyconfigs in total) cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/boegelbot/300088cff2df1d4ffc66b60a30dc14d3 for a full test report.

Killed by kill signal... OOM maybe? Again, it didn't show any issue in the original PR. I'll also retry this one...

@casparvl
Copy link
Contributor Author

casparvl commented May 7, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=20484 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20484 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13422

Test results coming soon (I hope)...

- notification for comment with ID 2098357508 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/66ddfbe2fab5efd4af16d29a1489b89b for a full test report.

@casparvl
Copy link
Contributor Author

casparvl commented May 7, 2024

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
gcn6.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz, 4 x NVIDIA NVIDIA A100-SXM4-40GB, 545.23.08, Python 3.6.8
See https://gist.github.com/casparvl/e6ba6617ec468a3710cf1b0244380569 for a full test report.

@casparvl casparvl marked this pull request as ready for review May 9, 2024 09:44
@akesandgren
Copy link
Contributor

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-cn1603.hpc2n.umu.se - Linux Ubuntu 22.04, x86_64, AMD EPYC 7313 16-Core Processor, Python 3.10.12
See https://gist.github.com/akesandgren/97e9d370702c8e4f3b44e6a44e0f6ddc for a full test report.

akesandgren
akesandgren approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @casparvl!

@akesandgren akesandgren merged commit 5ba17f7 into easybuilders:develop May 13, 2024
9 checks passed
@smoors smoors mentioned this pull request May 17, 2024
Merged
1 task
@boegel boegel changed the title {lib}[GCCcore/12.3.0] PyTorch-bundle-2.1.2 - Disable test that fetches from the web disable test that fetches from the web for torchtext extension in PyTorch-bundle v2.1.2 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.9.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@casparvl @boegelbot @akesandgren