Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{data}[foss/2023a] spaCy v3.7.4 #20774

Merged
merged 3 commits into from
Jun 18, 2024
Merged

{data}[foss/2023a] spaCy v3.7.4 #20774

merged 3 commits into from
Jun 18, 2024

Conversation

lcniel
Copy link
Contributor

@lcniel lcniel commented Jun 7, 2024

(created using eb --new-pr)

@lcniel
Copy link
Contributor Author

lcniel commented Jun 10, 2024

Test report by @lcniel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
alvis10-11 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, Python 3.6.8
See https://gist.github.com/lcniel/de199276355ab12e9490db05642839b0 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Jun 10, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis10-11 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, Python 3.6.8
See https://gist.github.com/lcniel/7c401fd1e9dd4f8edbecd09153fa054c for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Jun 10, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera11-1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, Python 3.6.8
See https://gist.github.com/lcniel/327d6ad3b7e5ffeb8ad901efa6346397 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Jun 10, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
vera-r08-11 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz, Python 3.6.8
See https://gist.github.com/lcniel/8831255ddcd83312c4148ed7648c5714 for a full test report.

smoors
smoors reviewed Jun 10, 2024
View reviewed changes
easybuild/easyconfigs/s/spaCy/spaCy-3.7.4-foss-2023a.eb Outdated
('SciPy-bundle', '2023.07'),
('tqdm', '4.66.1'),
('pydantic', '2.5.3'),
('hatchling', '1.18.0')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hatchling should most probably be a builddep instead of a dep

Copy link
Contributor Author

@lcniel lcniel Jun 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too but see line 484 https://gist.github.com/lcniel/c44522f699832ce8cfb28b110c7d5bf6:

hatch-fancy-pypi-readme 24.1.0 requires hatchling, which is not installed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a bit painful to have hatchling as runtime dep, it would collide with anything else which might pull different versions (as it's typically ok for something that's just a build dep).

In this case:
hatch-fancy-pypi-readme 24.1.0 requires hatchling, which is not installed.
this is an indirect dep for something that looks like a hatchling.

Either we split out hatch-fancy-pypi-readme as it's own package (like hatch-jupyter-builder-0.9.1-GCCcore-13.2.0.eb) and only use that as a builddep, or just skip this completely as it really does not seem necessary for the build. Making some fancy readme for pypi i guess? Nothing we will ever see of notice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to patch it out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it just works now without any added patching needed, just taking out the dep. Weird, will test more

@lcniel
Copy link
Contributor Author

lcniel commented Jun 17, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis10-12 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, Python 3.6.8
See https://gist.github.com/lcniel/cd19f61d4c86fca2e56dd48861f46a3b for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Jun 17, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis10-11 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, Python 3.6.8
See https://gist.github.com/lcniel/bc650ac79ae2e980af67daae20e33e6e for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Jun 17, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis2-17 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6226R CPU @ 2.90GHz, 1 x NVIDIA Tesla T4, 550.54.14, Python 3.6.8
See https://gist.github.com/lcniel/be404851a2084e7ff39e0c05382fc460 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Jun 18, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-gpu1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, 1 x NVIDIA Tesla V100-SXM2-32GB, 550.54.14, Python 3.6.8
See https://gist.github.com/lcniel/ee02f6074e2d4a2e09cd5f142e8823c1 for a full test report.

@lcniel
Copy link
Contributor Author

lcniel commented Jun 18, 2024

Test report by @lcniel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-r07-03 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6338 CPU @ 2.00GHz, 1 x NVIDIA NVIDIA A40, 550.54.14, Python 3.6.8
See https://gist.github.com/lcniel/eac7f32c4c28446e63f560a066239ba7 for a full test report.

@smoors
Copy link
Contributor

smoors commented Jun 18, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=20774 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20774 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13759

Test results coming soon (I hope)...

- notification for comment with ID 2175472672 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@zao
Copy link
Contributor

zao commented Jun 18, 2024

Test report by @zao
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
eb-mix.zao.se - Linux Ubuntu 24.04 LTS (Noble Numbat), x86_64, AMD Ryzen 9 3900X 12-Core Processor (zen2), Python 3.12.3
See https://gist.github.com/zao/e9bbe45bf7be92bae60506bc3f9e218a for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/40e078582949b8b0cc58451b2da57fb5 for a full test report.

@smoors
Copy link
Contributor

smoors commented Jun 18, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20774 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20774 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4406

Test results coming soon (I hope)...

- notification for comment with ID 2175548354 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/00679280aef74e3a078155a9128334ed for a full test report.

smoors
smoors approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added the update label Jun 18, 2024
@smoors smoors added this to the release after 4.9.2 milestone Jun 18, 2024
@smoors
Copy link
Contributor

smoors commented Jun 18, 2024

Going in, thanks @lcniel!

@smoors smoors merged commit baa9b83 into easybuilders:develop Jun 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket left review comments

@smoors smoors smoors approved these changes

Assignees
No one assigned
Labels
update
Projects
None yet
Milestone
release after 4.9.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lcniel @smoors @boegelbot @zao @Micket