Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external deps for safetensors and tokenizers in Transformers-4.29.2 #20868

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Micket
Copy link
Contributor

@Micket Micket commented Jun 20, 2024

(created using eb --new-pr)

see #20718

@Micket Micket added the update label Jun 20, 2024
@Micket Micket added this to the 5.0 milestone Jun 20, 2024
@Micket
Copy link
Contributor Author

Micket commented Jun 20, 2024

I'll try to get the safetensors 0.3.1 version working instead, but it might be difficult if it's already broken.

@Micket Micket marked this pull request as draft June 20, 2024 16:31
@Micket
Copy link
Contributor Author

Micket commented Jun 20, 2024

I need to verify that this works correctly before i mark this non-draft

@Micket
Copy link
Contributor Author

Micket commented Jun 20, 2024

Test report by @Micket
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/a40cb7f7e07222cbabf57dfd3e595ccd for a full test report.

@Micket Micket marked this pull request as ready for review June 20, 2024 20:21
@Micket
Copy link
Contributor Author

Micket commented Jun 20, 2024

AS far as i can tell, these all look fine, safetensors should support all the backends, numpy, torch, tensorflow, jax

@Micket
Copy link
Contributor Author

Micket commented Jun 20, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20868 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20868 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13792

Test results coming soon (I hope)...

- notification for comment with ID 2181560553 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2cb8e0034b2224563e60464db2b4614d for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Jun 20, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20868 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20868 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4438

Test results coming soon (I hope)...

- notification for comment with ID 2181615101 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/e9c6a8c89ac97edc1dd56becc7742c96 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants