Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable auto-vectorizer (-ftree-vectorize) for OpenFOAM v10 + v11 when using toolchain that with GCC >= 11 #20958

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Jul 3, 2024

(created using eb --new-pr)
fixes #20927

@boegel boegel changed the title disable auto-vectorizer (-ftree-vectorize) for OpenFOAM v10 + v11 when using toolchain that with GCC >= 11 disable auto-vectorizer (-ftree-vectorize) for OpenFOAM v10 + v11 when using toolchain that with GCC >= 11 Jul 3, 2024
@boegel boegel added the bug fix label Jul 3, 2024
@boegel boegel added this to the release after 4.9.2 milestone Jul 3, 2024
@boegel
Copy link
Member Author

boegel commented Jul 3, 2024

Although @Micket mentioned that using -O3 (with -ftree-vectorize) may also work to circumvent the problem reported in #20927, I still feel the change being made here makes sense, since we already disable -ftree-vectorize for the other OpenFOAM variant since:

@boegel
Copy link
Member Author

boegel commented Jul 3, 2024

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20958 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20958 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4511

Test results coming soon (I hope)...

- notification for comment with ID 2206785445 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented Jul 3, 2024

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20958 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20958 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13876

Test results coming soon (I hope)...

- notification for comment with ID 2206811407 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 6 (6 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/d936ff97c42576d451b85dc84950c5a5 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cnx2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/babcd6464fe03203fae49815caa2857e for a full test report.

@boegel
Copy link
Member Author

boegel commented Jul 4, 2024

Test report by @boegelbot FAILED Build succeeded for 3 out of 6 (6 easyconfigs in total) jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18 See https://gist.github.com/boegelbot/d936ff97c42576d451b85dc84950c5a5 for a full test report.

Tests for OpenFOAM-10-foss-2022a*eb failed because of interference of #20949 where the OpenMPI component of foss/2022a was being rebuilt.

@boegel
Copy link
Member Author

boegel commented Jul 4, 2024

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="OpenFOAM-10-foss-2022a-20230119-int64.eb OpenFOAM-10-foss-2022a-20230119.eb OpenFOAM-10-foss-2022a.eb"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20958 EB_ARGS="OpenFOAM-10-foss-2022a-20230119-int64.eb OpenFOAM-10-foss-2022a-20230119.eb OpenFOAM-10-foss-2022a.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20958 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4519

Test results coming soon (I hope)...

- notification for comment with ID 2208172546 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/cee33b7aa7862209794962312237871f for a full test report.

@boegel
Copy link
Member Author

boegel commented Jul 4, 2024

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3158.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/9dafcbcf1266a8cfd969372eeb9cc8c0 for a full test report.

@jfgrimm jfgrimm merged commit 1610c40 into easybuilders:develop Jul 4, 2024
9 checks passed
@boegel boegel deleted the 20240703153549_new_pr_OpenFOAM10 branch July 5, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect results for OpenFOAM v10 + v11 when built with GCC 11.3.0 or 12.3.0 and -ftree-vectorize
3 participants