add easyconfig files for openmc software stack #20965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
reviewed
Jul 8, 2024
easybuild/easyconfigs/d/double-down/double-down-1.1.0-foss-2022a.eb
Outdated
Show resolved
Hide resolved
Flamefire
reviewed
Jul 8, 2024
easybuild/easyconfigs/d/double-down/double-down-1.1.0-foss-2022a.eb
Outdated
Show resolved
Hide resolved
Flamefire
reviewed
Jul 8, 2024
easybuild/easyconfigs/d/double-down/double-down-1.1.0-foss-2022a.eb
Outdated
Show resolved
Hide resolved
Flamefire
reviewed
Jul 8, 2024
Flamefire
reviewed
Jul 10, 2024
| ('fmt','9.1.0'), | ||
| ('gsl-lite','0.41.0'), | ||
| ('pugixml','1.12.1'), | ||
| ('xtensor','0.24.7') |
There was a problem hiding this comment.
Try to always include the comma for the last element when having them on multiple lines. E.g. here the mcpl line has changed although it didn't really.
Suggested change
| ('xtensor','0.24.7') | |
| ('xtensor','0.24.7'), |
Flamefire
reviewed
Jul 10, 2024
| @@ -0,0 +1,48 @@ | |||
| diff --unified --recursive --text openmc-0.15.0.orig/CMakeLists.txt openmc-0.15.0.new/CMakeLists.txt | |||
There was a problem hiding this comment.
Is this patch from upstream? If so please include a link (and a description in general)
If not, wouldn't it be easier to just remove the check instead of this large patch (due to aligning existing options) and passing an extra configure flag? If the patch is just for EB the flexibility isn't necessary, is it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces a set of easyconfig files for the OpenMC software stack. OpenMC is a monte-carlo particle transport software. It can be configured with or without DAGMC, a geometry engine for running particle transport on CAD models, and thus includes an easyconfig and relevant dependencies for both cases.