Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RISC-V support to x264-20231019/GCCcore-13.2.0 #20968

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Jul 5, 2024

(created using eb --new-pr)

The issue is due to the config.guess being very outdated. EB doesn't automatically update it, because the configure script wasn't generated by Autoconf (it's a custom bash script). The patch is taken from an upstream PR that adds RISC-V support to the config.guess.

@bedroge bedroge added enhancement EESSI Related to EESSI project riscv labels Jul 5, 2024
@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
starfive - Linux Debian GNU/Linux n/a, RISC-V-64, UNKNOWN, Python 3.10.9
See https://gist.github.com/bedroge/33f6fa11d28c7b1c1a9b63bdfe2eda89 for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.12
See https://gist.github.com/bedroge/315ea2a7792e1dfe21d118ee765c444c for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=20968 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20968 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13895

Test results coming soon (I hope)...

- notification for comment with ID 2210891604 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c4fad4afee63eb76c013713f0d23827f for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20968 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20968 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4528

Test results coming soon (I hope)...

- notification for comment with ID 2210910031 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/130044b5aea09bd6a46e30c562de74be for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
interactive1 - Linux Rocky Linux 8.9, x86_64, AMD EPYC-Milan Processor (zen2), Python 3.6.8
See https://gist.github.com/bedroge/a966a9935f2e21ce86fc254ea2462de4 for a full test report.

@SebastianAchilles SebastianAchilles added this to the release after 4.9.2 milestone Jul 5, 2024
@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
arriesgado-7 - Linux Ubuntu 22.04, RISC-V-64, UNKNOWN (u74mc), Python 3.10.12
See https://gist.github.com/SebastianAchilles/38f3d88f30d4ce5729ebc82f70b3da43 for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @bedroge!

@SebastianAchilles SebastianAchilles merged commit 49dee66 into easybuilders:develop Jul 5, 2024
9 checks passed
@bedroge bedroge deleted the 20240705152646_new_pr_x26420231019 branch July 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EESSI Related to EESSI project enhancement riscv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants