Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RISC-v support to recent LAME easyconfigs by removing workaround for finding libncurses #20970

Merged

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Jul 5, 2024

This workaround would set an environment variable with configure_cmd_prefix, and this is somewhat ugly. It also breaks the config.guess update functionality in the configuremake easyblock, as this will check if configure_command exists, and it will think it doesn't exist if the command includes this environment variable (as it's basically doing os.path.exists("FRONTEND_LDADD='-L${EBROOTNCURSES}/lib' ./configure"). See https://github.com/easybuilders/easybuild-easyblocks/blob/develop/easybuild/easyblocks/generic/configuremake.py#L303. As LAME includes a very old config.guess, it doesn't build on RISC-V this way.

I couldn't reproduce any issues with the workaround removed, and without it LAME would indeed build fine on RISC-V, as the easyblock then does update the config.guess. So I'm proposing that we remove this workaround. If it would still be needed for any reason, we should just set it in (pre)configopts.

@bedroge bedroge added enhancement EESSI Related to EESSI project riscv labels Jul 5, 2024
@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
starfive - Linux Debian GNU/Linux n/a, RISC-V-64, UNKNOWN, Python 3.10.9
See https://gist.github.com/bedroge/1fc6f62084dda7a8e79650a071a149a9 for a full test report.

Only tried the GCCcore 13.2.0 version on RISC-V, as it doesn't really support older GCC versions.

@bedroge bedroge changed the title remove workaround for finding libncurses in recent LAME easyconfigs remove workaround for finding libncurses in recent LAME easyconfigs (which adds RISC-V support) Jul 5, 2024
@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.12
See https://gist.github.com/bedroge/97c0be3f60f8783c7ed41877b4f19308 for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=20970 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20970 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13896

Test results coming soon (I hope)...

- notification for comment with ID 2210993808 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
interactive1 - Linux Rocky Linux 8.9, x86_64, AMD EPYC-Milan Processor (zen2), Python 3.6.8
See https://gist.github.com/bedroge/ac3b7e7fb999fc1ae45d7b2a3b159430 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/20d8c0055253a239804a7e5c2f49973e for a full test report.

@bedroge
Copy link
Contributor Author

bedroge commented Jul 5, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20970 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20970 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4529

Test results coming soon (I hope)...

- notification for comment with ID 2211084066 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/24750aa6fb4b22c1f1bb20d673174237 for a full test report.

@SebastianAchilles SebastianAchilles added this to the release after 4.9.2 milestone Jul 5, 2024
@bedroge bedroge changed the title remove workaround for finding libncurses in recent LAME easyconfigs (which adds RISC-V support) add RISC-v support to recent LAME easyconfigs by removing workaround for finding libncurses Jul 5, 2024
@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
arriesgado-7 - Linux Ubuntu 22.04, RISC-V-64, UNKNOWN (u74mc), Python 3.10.12
See https://gist.github.com/SebastianAchilles/6b8bfeaf1ccd344f3eddc370542eba15 for a full test report.

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 77 out of 77 (5 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/934c9c98f7382f52ed82caf8007e0d49 for a full test report.

Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

Going in, thanks @bedroge!

@verdurin verdurin merged commit e9211da into easybuilders:develop Jul 11, 2024
9 checks passed
@bedroge bedroge deleted the lame_remove_ncurses_workaround branch July 11, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EESSI Related to EESSI project enhancement riscv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants