Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update easyconfigs.py - add exception for VTK-9.2.6 #20982

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pavelToman
Copy link
Contributor

@pavelToman pavelToman commented Jul 9, 2024

Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin added this to the release after 4.9.2 milestone Jul 11, 2024
@verdurin
Copy link
Member

@pavelToman it's easier to test this along with the application itself, so please add this change to #20981 and close this PR.

@pavelToman
Copy link
Contributor Author

@pavelToman it's easier to test this along with the application itself, so please add this change to #20981 and close this PR.

That was my intent, but I was unable to add it to #20981, could you hint me how please?

@verdurin
Copy link
Member

@pavelToman can't you just add it as a new file, the same way you might do if you had forgotten to include a new patch file (for example)?

@pavelToman
Copy link
Contributor Author

@pavelToman can't you just add it as a new file, the same way you might do if you had forgotten to include a new patch file (for example)?

Normally I add the file by eb --update-pr but I can not do it with this file. I had to find it here on GitHub and modify it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visit
2 participants