Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[foss/2023b] Biopython v1.84 #21025

Conversation

fizwit
Copy link
Contributor

@fizwit fizwit commented Jul 19, 2024

(created using eb --new-pr)

@migueldiascosta migueldiascosta added this to the release after 4.9.2 milestone Jul 23, 2024
@migueldiascosta migueldiascosta changed the title update Biopython {bio}[foss/2023b] Biopython v1.84 Jul 23, 2024
@migueldiascosta
Copy link
Member

migueldiascosta commented Jul 23, 2024

@fizwit just to explain why I changed the title, since you do seem to be using --new-pr and specified a --pr-commit-message (that's only necessary when an existing easyconfig is being changed, which is not the case here), the reason is that the automatic titles help us somewhat when filtering through the PRs in order to compose the release notes at each release. It's not a very big deal since we do cross check those assumptions, but sticking to the defaults does make it easier. Just FYI.

@migueldiascosta
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=21025 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21025 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13946

Test results coming soon (I hope)...

- notification for comment with ID 2246473382 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/cbf4b00a1bc83f9094afc1887ff1787f for a full test report.

@migueldiascosta
Copy link
Member

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21025 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21025 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4579

Test results coming soon (I hope)...

- notification for comment with ID 2246498184 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/f49280290d32c7c3354d69d929493366 for a full test report.

@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
gracehopper - Linux Rocky Linux 9.3, AArch64, ARM UNKNOWN (neoverse_v2), 1 x NVIDIA NVIDIA GH200 480GB, 550.54.15, Python 3.9.18
See https://gist.github.com/migueldiascosta/aabf561759dd705a9667c0fddfd31e82 for a full test report.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @fizwit!

@migueldiascosta migueldiascosta merged commit c591ee1 into easybuilders:develop Jul 23, 2024
9 checks passed
@fizwit
Copy link
Contributor Author

fizwit commented Jul 25, 2024

@fizwit just to explain why I changed the title, since you do seem to be using --new-pr and specified a --pr-commit-message (that's only necessary when an existing easyconfig is being changed, which is not the case here), the reason is that the automatic titles help us somewhat when filtering through the PRs in order to compose the release notes at each release. It's not a very big deal since we do cross check those assumptions, but sticking to the defaults does make it easier. Just FYI.

Should I be using --pr-title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants