New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{tools}[dummy/dummy] hub 2.2.2 (REVIEW) #2249
Conversation
Automatic reply from Jenkins: Can I test this? |
homepage = 'https://hub.github.com/' | ||
description = """hub is a command-line wrapper for git that makes you better at GitHub.""" | ||
|
||
sources = ['%%(namelower)s-%s-%%(version)s.tgz' % versionsuffix[1:]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe change this to:
source_urls = ['https://github.com/github/hub/releases/download/v%(version)s/']
sources = ['%(namelower)s%(versionsuffix)s-%(version)s.tgz']
@nathanhaigh: have you tried building it from source? We already have easyconfigs for Go, so may be easy? |
Jenkins: ok to test |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5397/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
I did try building from source, but hub recommends using the binaries. I haven't any experience with Go and only marginally more with EasyBuild! I wasn't sure what EasyBlock to use and if there are existing tools using it which I could learn from. Happy to submit a PR for an easyconfig building from source if I can get a bit of guidance. |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5400/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@nathanhaigh: ok, no problem, it's just that we try to stay away from binary packages when we can (not sure if it matters a lot for tools written in Go though); let's follow this up in the issue you opened (#2251) |
Test report by @boegel |
Going in, thanks @nathanhaigh! |
Hold off merging this for the moment. I'm experiencing some odd behaviour once I've loaded the module and then run What I've noticed is that during the |
This is what
Notice that last Other than the
So I'm wondering how best to deal with all of these things. |
Hmm, for some reason I ended up not hitting the merge button on this on yet, even though I intended to. The problem you ran into is indeed worrying. It's caused by the |
The reason this is so bad is that the install script provided by Not adding the install dir to PATH would work - can you make those changes @boegel? |
Damn, deleted my branch by mistake - restored it now :) |
Automatic reply from Jenkins: Can I test this? |
1 similar comment
Automatic reply from Jenkins: Can I test this? |
This avoids issues with the `installdir` being unconditionally added to the PATH by the module.
@boegel the latest commit addresses these issues without the need to modify what gets prepended to |
Jenkins: ok to test |
|
||
toolchain = {'name': 'dummy', 'version': 'dummy'} | ||
|
||
postinstallcmds = ['chmod -x %(installdir)s/install'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, are you sure this is OK? Why is this script there at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, here's more info easybuilders/easybuild-easyblocks#801
The actual install
script provided by hub
can be seen here: https://github.com/github/hub/blob/master/script/install.sh. Line 22 ends up calling itself recursively because the installdir
is added to the PATH
.
Making the script non-executable is a workaround.
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5583/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
Test report by @boegel |
lgtm |
Going in, thanks @nathanhaigh! |
Easyconfig for installing hub 2.2.2.