{bio} [goolf-1.4.10] BayeScan-2.1 (REVIEW) #2748
Conversation
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7190/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| description = """BayeScan aims at identifying candidate loci under natural selection from genetic data, | ||
| using differences in allele frequencies between populations.""" | ||
|
|
||
| # BayeScan makefile is hardcoded to use g++. In case you want to use a non-gcc toolchain you will need to patch the makefile |
There was a problem hiding this comment.
I would rather see this problem being dealt with, otherwise it'll be missed easily when someone uses --try-toolchain on this...
I think this would work:
prebuildopts = "sed -i .bk 's/g\+\+/${CC} ${CFLAGS}/g' Makefile && "Note that if you're not using $CFLAGS, you'll end up using the default for GCC, which is -O0 (i.e. NO optimisations). You really don't want that...
|
Test report by @boegel |
|
lgtm |
|
Going in, thanks @pescobar! |
No description provided.