New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAST with foss2016a #3288
PLAST with foss2016a #3288
Conversation
|
||
homepage = "http://www.irisa.fr/symbiose/projects/plast/" | ||
description = """ | ||
PLAST is a parallel alignment search tool for comparing large protein banks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to wrap, use single line?
Test report by @boegel |
Test report by @boegel |
@RvDijk missing dep?
|
@boegel Perl only is used in order to set the date, should it be in the name of this easyconfig? I guess that Perl is a build dependency, but %(perlver)s does not work in build dependencies. |
@RvDijk what do you mean exactly with I would consider |
|
||
dependencies = [ | ||
('Java', '1.8.0_92', '', True), | ||
('Perl', '5.22.1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RvDijk still a runtime dep (in disagreement with your commit message)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, spoke too soon :)
@boegel it seems that Perl only is used to retrieve the date and put it in a variable. Therefore putting it in the build dependencies is fine. |
sources=['%(namelower)s_source_v%(version)s.tar.gz'] | ||
|
||
builddependencies = [ | ||
('CMake', '3.5.2') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RvDijk missing ,
at the end of this line, leading to a parse error: TypeError: 'tuple' object is not callable
Test report by @boegel |
lgtm |
Test report by @boegel |
Going in, thanks @RvDijk! |
No description provided.