Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAST with foss2016a #3288

Merged
merged 7 commits into from Aug 26, 2016
Merged

Conversation

RvDijk
Copy link
Contributor

@RvDijk RvDijk commented Jul 4, 2016

No description provided.


homepage = "http://www.irisa.fr/symbiose/projects/plast/"
description = """
PLAST is a parallel alignment search tool for comparing large protein banks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to wrap, use single line?

@boegel boegel added this to the v2.8.2 milestone Jul 5, 2016
@boegel
Copy link
Member

boegel commented Jul 5, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2496.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/55fca242b8114a7b7fcd1ac3492691db for a full test report.

@boegel
Copy link
Member

boegel commented Jul 5, 2016

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2099.delcatty.os - Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/1d5f54c306c24b0bb29162dee9bba875 for a full test report.

@boegel
Copy link
Member

boegel commented Jul 7, 2016

@RvDijk missing dep?

CMake Error at /user/scratchdelcatty/gent/gvo000/gvo00002/vsc40023/easybuild_REGTEST/SL6/sandybridge/software/CMake/3.5.2-foss-2016a/share/cmake-3.5/Modules/FindPackageHandleStandardArgs.cmake:148 (message):
  Could NOT find JNI (missing: JAVA_AWT_LIBRARY JAVA_JVM_LIBRARY
  JAVA_INCLUDE_PATH JAVA_INCLUDE_PATH2 JAVA_AWT_INCLUDE_PATH)

@boegel boegel modified the milestones: v2.9.0, v2.8.2 Jul 7, 2016
@RvDijk
Copy link
Contributor Author

RvDijk commented Jul 18, 2016

@boegel Perl only is used in order to set the date, should it be in the name of this easyconfig? I guess that Perl is a build dependency, but %(perlver)s does not work in build dependencies.

@boegel
Copy link
Member

boegel commented Aug 10, 2016

@RvDijk what do you mean exactly with set the date? It does sound like Perl is just a build dep here, and in that case if should not be in the versionsuffix indeed.

I would consider %(perlver)s not working for build dependencies a bug though (although a low priority one), so please open an issue for that at https://github.com/hpcugent/easybuild-framework/issues


dependencies = [
('Java', '1.8.0_92', '', True),
('Perl', '5.22.1')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RvDijk still a runtime dep (in disagreement with your commit message)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, spoke too soon :)

@RvDijk
Copy link
Contributor Author

RvDijk commented Aug 25, 2016

@boegel it seems that Perl only is used to retrieve the date and put it in a variable. Therefore putting it in the build dependencies is fine.

sources=['%(namelower)s_source_v%(version)s.tar.gz']

builddependencies = [
('CMake', '3.5.2')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RvDijk missing , at the end of this line, leading to a parse error: TypeError: 'tuple' object is not callable

@boegel
Copy link
Member

boegel commented Aug 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2130.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/a7fdeac54a5cba21da76e7a74b77c08e for a full test report.

@boegel
Copy link
Member

boegel commented Aug 26, 2016

lgtm

@boegel
Copy link
Member

boegel commented Aug 26, 2016

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2539.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/067dd2f215ceee374ed4f1f8d6bda85f for a full test report.

@boegel
Copy link
Member

boegel commented Aug 26, 2016

Going in, thanks @RvDijk!

@boegel boegel merged commit 0601fc0 into easybuilders:develop Aug 26, 2016
@RvDijk RvDijk deleted the PLAST-foss2016a branch August 26, 2016 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants