Statically link ncurses... #3545

ocaisa · 2016-09-07T11:09:40Z

so it's not needed at runtime

ocaisa · 2016-09-07T11:11:49Z

Fixes an issue for easybuilders/easybuild-framework#1882

boegel · 2016-09-07T11:16:48Z

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2011.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/1463f1402793e43b7738ef6f68220134 for a full test report.

boegel · 2016-09-07T11:18:03Z

This breaks the build, requires another build dep?

ocaisa · 2016-09-07T11:23:07Z

Yeah, libreadline...I'm on it

Add libreadline dep to Lua for static build

boegel · 2016-09-07T14:53:27Z

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
node2601.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5c3303ac90ceea87960a213cf33fc024 for a full test report.

ocaisa · 2016-09-07T15:02:38Z

Hmm, not sure what to do here, the libtinfo functionality is inside libncurses, not sure why Lua is requesting it, I'll take a look at the configure script

ocaisa · 2016-09-07T15:09:38Z

I think using pkg-config for ncurses and Lua might solve this problem...but I can't reproduce the problem to check. I'll blindly throw it in and see if that fixes it for you

boegel · 2016-09-07T17:00:33Z

Test report by @boegel
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in this PR)
node2141.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/b476ee6d397b2a2d6679871ada221315 for a full test report.

boegel · 2016-09-07T17:45:57Z

Test report by @boegel
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in this PR)
node2603.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4c6ffa026d43689246ed3b6ac6d8129b for a full test report.

…o patch-4

boegel · 2016-09-08T10:17:26Z

easybuild/easyconfigs/n/ncurses/ncurses-6.0.eb

@@ -16,9 +16,10 @@ sources = [SOURCE_TAR_GZ]

 configopts = [
    # default build
-    '--with-shared --enable-overwrite',
+    '--with-shared --enable-overwrite --with-termlib',


@ocaisa this should be reflected in the sanity_check_paths too?

@ocaisa Why exactly was this required here? It makes this ncurses easyconfig that uses dummy different from the other ncurses easyconfigs, which causes problems (see also easybuilders/easybuild-easyblocks#1088).

I'm not saying we should blindly revert this change, since the split is already taken into account elsewhere (for example in https://github.com/easybuilders/easybuild-easyconfigs/pull/4977/files#diff-03dfb6d80d1923383727d96e696cc53fR20), just wondering what the exact reason was for this.

cc @pforai

I only had to do this to be able to build lua at the dummy level, it was never an issue for me, it was an issue for the tests. (from what I remember)

OK, thanks for clarifying.

Looking back at the test report at https://gist.github.com/boegel/5c3303ac90ceea87960a213cf33fc024, building Lua-5.1.4-8.eb was indeed failing without the split:

gcc -o lua lua.o liblua.a -lm -Wl,-E -ldl -Wl,-Bstatic -lhistory -lreadline -ltinfo -lncurses -Wl,-Bdynamic gcc -o luac luac.o print.o liblua.a -lm -Wl,-E -ldl -Wl,-Bstatic -lhistory -lreadline -ltinfo -lncurses -Wl,-Bdynamic /usr/bin/ld: cannot find -ltinfo /usr/bin/ld: cannot find -ltinfo

Maybe the proper fix would have been to not let Lua link with -ltinfo though...

@vanzod
Ok, I think I have a fix for this but some may consider it hackish.

Some systems do expect a separate tinfo by default (Ubuntu 16.04) and in that case if we don't provide libtinfo from ncurses, some configures (such as the Lua one in the original PR) will pick it up from the OS. To get around this we can just do a soft link of libtinfo.so -> libncurses.so after installing ncurses which is what debian has done in the past.

I also found (what I think is) a problem with our libreadline easyconfigs. I'm not sure of the purpose of the linking to ncurses there, but if we are expecting ncurses to be force-linked in the final .so then we are not doing it right, the correct option ( for v6.3) is

buildopts = "SHLIB_LIBS='-lncurses'"

(from http://www.linuxfromscratch.org/lfs/view/7.4/chapter06/readline.html)

With those two options I can revert the ncurses build to be more like the rest. I'll open a PR and we can discuss further there.

boegel · 2016-09-08T10:19:50Z

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2415.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/41081035cc919dc785a9ff766a850d00 for a full test report.

boegel · 2016-09-08T10:29:05Z

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2415.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/8be0cada6ab2e46779eba9cce4374a53 for a full test report.

boegel · 2016-09-08T10:30:21Z

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2017.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/871962c0b0d5432761d11b89fb14f0d0 for a full test report.

boegel · 2016-09-08T10:54:37Z

lgtm

boegel · 2016-09-08T10:54:47Z

Going in, thanks @ocaisa!

ocaisa · 2016-09-08T10:55:25Z

It works but gives me a strange end result, I'm not sure it does what I think it does. For my case if I don't include the libreadline dep and I say to link statically, I get a lua executable that doesn't depend on anything other than basic system libs

ocaisa · 2016-09-08T10:57:28Z

Maybe not, just repeated and things are different, I must have made a mistake

boegel · 2016-09-08T10:58:06Z

Looks OK on my end:

$ ml Lua/5.1.4-8
$ ldd $(which lua)
        linux-vdso.so.1 =>  (0x00002aaaaaaab000)
        libm.so.6 => /lib64/libm.so.6 (0x00002aaaaaac0000)
        libdl.so.2 => /lib64/libdl.so.2 (0x00002aaaaadc3000)
        libc.so.6 => /lib64/libc.so.6 (0x00002aaaaafc7000)
        /lib64/ld-linux-x86-64.so.2 (0x0000555555554000)
$ which lua
/user/scratch/gent/vsc400/vsc40023/easybuild_REGTEST/CO7/haswell-ib/software/Lua/5.1.4-8/bin/lua

ocaisa · 2016-09-08T10:59:52Z

Yeah, you are right, I messed it up somehow

…(see easybuilders#3545) creating a soft link 'libtinfo.so -> libncurses.so' and extending it to create soft links 'libtinfo.so.5.9 -> libncurses.so.5.9' and 'libtinfo.so.5 -> libncurses.so.5' as well.

Statically link ncurses...

a24fb94

so it's not needed at runtime

boegel added this to the v2.9.0 milestone Sep 7, 2016

Alan added 2 commits September 7, 2016 16:30

Add libreadline dep to Lua for static build

a22bc69

Merge pull request #22 from ocaisa/origin/patch-4

fba9c89

Add libreadline dep to Lua for static build

Add pkg-config to solve libtinfo problem related to ncurses

45c4c8e

Alan added 3 commits September 8, 2016 12:04

Add configure option to solve libtinfo problem related to ncurses

351c4a1

Merge branch 'patch-4' of github.com:ocaisa/easybuild-easyconfigs int…

508c6c7

…o patch-4

Make ncurses build the terminfo library separately

070f0a5

boegel reviewed Sep 8, 2016
View reviewed changes

Check for terminfo libs during sanitycheck

fa54afe

boegel merged commit 3ad68d2 into easybuilders:develop Sep 8, 2016

ocaisa deleted the patch-4 branch September 8, 2016 11:00

vanzod mentioned this pull request Jan 18, 2017

Separate terminfo library in ncurses breaks Python build #4049

Closed

vanzod mentioned this pull request May 9, 2017

make sure no modules are loaded when EasyBuild is started easybuilders/easybuild-framework#153

Closed

boegel mentioned this pull request Aug 29, 2017

Update ncurses to not build a separate libtinfo but provide a soft link instead. Force linking to ncurses in libreadline #5067

Merged

MaximeMoge mentioned this pull request Oct 21, 2021

{data}[GCCcore/10.3.0] Stata v17 #14144

Closed

lexming mentioned this pull request Jul 22, 2022

build libtinfo and multithreaded targets of ncurses #15897

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Statically link ncurses... #3545

Statically link ncurses... #3545

ocaisa commented Sep 7, 2016

ocaisa commented Sep 7, 2016

boegel commented Sep 7, 2016

boegel commented Sep 7, 2016

ocaisa commented Sep 7, 2016

boegel commented Sep 7, 2016

ocaisa commented Sep 7, 2016

ocaisa commented Sep 7, 2016

boegel commented Sep 7, 2016

boegel commented Sep 7, 2016

boegel Sep 8, 2016

boegel Aug 10, 2017

ocaisa Aug 11, 2017 •

edited

boegel Aug 11, 2017

ocaisa Aug 28, 2017

ocaisa Aug 28, 2017

boegel commented Sep 8, 2016

boegel commented Sep 8, 2016

boegel commented Sep 8, 2016

boegel commented Sep 8, 2016

boegel commented Sep 8, 2016

ocaisa commented Sep 8, 2016

ocaisa commented Sep 8, 2016

boegel commented Sep 8, 2016

ocaisa commented Sep 8, 2016

Statically link ncurses... #3545

Statically link ncurses... #3545

Conversation

ocaisa commented Sep 7, 2016

ocaisa commented Sep 7, 2016

boegel commented Sep 7, 2016

boegel commented Sep 7, 2016

ocaisa commented Sep 7, 2016

boegel commented Sep 7, 2016

ocaisa commented Sep 7, 2016

ocaisa commented Sep 7, 2016

boegel commented Sep 7, 2016

boegel commented Sep 7, 2016

boegel Sep 8, 2016

Choose a reason for hiding this comment

boegel Aug 10, 2017

Choose a reason for hiding this comment

ocaisa Aug 11, 2017 • edited

Choose a reason for hiding this comment

boegel Aug 11, 2017

Choose a reason for hiding this comment

ocaisa Aug 28, 2017

Choose a reason for hiding this comment

ocaisa Aug 28, 2017

Choose a reason for hiding this comment

boegel commented Sep 8, 2016

boegel commented Sep 8, 2016

boegel commented Sep 8, 2016

boegel commented Sep 8, 2016

boegel commented Sep 8, 2016

ocaisa commented Sep 8, 2016

ocaisa commented Sep 8, 2016

boegel commented Sep 8, 2016

ocaisa commented Sep 8, 2016

ocaisa Aug 11, 2017 •

edited