Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meRanTK-1.1.1b added #4175

Merged
merged 3 commits into from
Feb 23, 2017
Merged

meRanTK-1.1.1b added #4175

merged 3 commits into from
Feb 23, 2017

Conversation

manifestoso
Copy link
Contributor

No description provided.

@boegel
Copy link
Member

boegel commented Feb 22, 2017

@migueldiascosta please review?

@boegel boegel added this to the 3.2.0 milestone Feb 22, 2017
@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.8, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.6.6
See https://gist.github.com/332732f0f580b6bade383374abc17a32 for a full test report.

migueldiascosta
migueldiascosta requested changes Feb 22, 2017
View reviewed changes
easybuild/easyconfigs/m/meRanTK/meRanTK-1.1.1b.eb Outdated
# Homepage: https://www.adelaide.edu.au/phoenix/
#
# Copyright:: adelaide.edu.au/phoenix
# Authors:: Robert Qiao <robert.qiao@adelaide.edu.au>, Exequiel Manuel Sepulveda Escobedo <exequiel.sepulvedaescobedo@adelaide.edu.au>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (134 > 120 characters)

easybuild/easyconfigs/m/meRanTK/meRanTK-1.1.1b.eb Outdated
toolchain = {'name': 'dummy', 'version': 'dummy'}

source_urls = ['http://www.icbi.at/software/meRanTK/downloads']
sources = ['%s/meRanTK-%s.zip' %(version,version,)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be

source_urls = ['http://www.icbi.at/software/meRanTK/downloads/%(version)s/']
sources = ['meRanTK-%(version)s.zip']

easybuild/easyconfigs/m/meRanTK/meRanTK-1.1.1b.eb Outdated
]

sanity_check_paths = {
'files':['bin/meRanAnnotate'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use spaces for indentation instead of tabs, and should be a single files list, e.g.

    'files': ['bin/meRan%s' % x for x in ['Annotate', 'Call', 'Compare', 'Gs', 'Gt', 'T']],

easybuild/easyconfigs/m/meRanTK/meRanTK-1.1.1b.eb Outdated
sources = ['%s/meRanTK-%s.zip' %(version,version,)]

dependencies = [
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there are no dependencies, unnecessary?

easybuild/easyconfigs/m/meRanTK/meRanTK-1.1.1b.eb Outdated
name = 'meRanTK'
version = '1.1.1b'

easyblock = 'BinariesTarball'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easyblock should be on top, above name =, and with an empty line in between

migueldiascosta
migueldiascosta reviewed Feb 23, 2017
View reviewed changes
easybuild/easyconfigs/m/meRanTK/meRanTK-1.1.1b.eb Outdated
'files':['bin/meRanGs'],
'files':['bin/meRanGt'],
'files':['bin/meRanT'],
'dirs':[],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'dirs': [], is still required (that's why Travis is failing), sorry if I wasn't clear

migueldiascosta
migueldiascosta reviewed Feb 23, 2017
View reviewed changes
easybuild/easyconfigs/m/meRanTK/meRanTK-1.1.1b.eb Outdated
'files':['bin/meRanGt'],
'files':['bin/meRanT'],
'dirs':[],
'files': ['bin/meRan%s' % x for x in ['Annotate', 'Call', 'Compare', 'Gs', 'Gt', 'T']],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continuation line under-indented for hanging indent (needs 4 spaces instead of 1). With EasyBuild >= 3.1.0, you can use the --check-style option (easybuilders/easybuild-framework/pull/2038)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds very handy, thanks.

migueldiascosta
migueldiascosta approved these changes Feb 23, 2017
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 23, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2001.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/958ab84e2040ec65c7b6d649390f4b2e for a full test report.

@boegel
Copy link
Member

boegel commented Feb 23, 2017

Thanks for the thorough review @migueldiascosta!

@boegel
Copy link
Member

boegel commented Feb 23, 2017

Going in, thanks @robqiao!

@boegel boegel merged commit 2d809f2 into easybuilders:develop Feb 23, 2017
@manifestoso manifestoso deleted the develop branch February 23, 2017 08:51
@boegel boegel modified the milestones: 3.2.0, 3.1.1 Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manifestoso @boegel @migueldiascosta