yet another batch of minor style fixes (g) #4275
Conversation
| @@ -103,7 +103,8 @@ full_sanity_check = True | |||
| eggname = 'gc3pie-%%(version)s-py%s.egg' % pyver | |||
| sanity_check_paths = { | |||
| 'files': ['bin/gc3utils', | |||
| ('lib/python%s/site-packages/%s' % (pyver, eggname), 'lib64/python%s/site-packages/%s' % (pyver, eggname))], | |||
| ('lib/python%s/site-packages/%s' % (pyver, eggname), | |||
| 'lib64/python%s/site-packages/%s' % (pyver, eggname))], | |||
There was a problem hiding this comment.
@migueldiascosta we usually tend to avoid checking for actual `.egg's more recently, since they could be either a file or a directory, depending on a number of things.
In addition, an import gc3pie check is already done too.
So, I'd change this to:
('lib/python%s/site-packages' % pyver, 'lib64/python%s/site-packages'),and move it to dirs?
| @@ -21,7 +21,8 @@ dependencies = [ | |||
|
|
|||
| builddependencies = [('Python', '2.7.11')] | |||
|
|
|||
| configopts = "--disable-maintainer-mode --disable-silent-rules --disable-libelf --enable-static --enable-shared --disable-systemtap" | |||
| configopts = "--disable-maintainer-mode --disable-silent-rules --disable-libelf --enable-static --enable-shared " | |||
| configopts += "--disable-systemtap" | |||
There was a problem hiding this comment.
but this --disable with the others, and move the --enable-* ones to a new line instead?
| @@ -10,7 +10,8 @@ description = """Ghostscript is a versatile processor for PostScript data with t | |||
| toolchain = {'name': 'intel', 'version': '2016a'} | |||
| toolchainopts = {'pic': True} | |||
|
|
|||
| source_urls = ["https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/download/gs%(version_major)s%(version_minor)s/"] | |||
| source_subdir = 'gs%(version_major)s%(version_minor)s' | |||
| source_urls = ["https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/download/%s/" % source_subdir] | |||
| @@ -21,7 +21,8 @@ dependencies = [ | |||
| ] | |||
|
|
|||
| sanity_check_paths = { | |||
| 'files': ['lib/gtkglext-1.0/include/gdkglext-config.h', 'lib/libgdkglext-x11-1.0.a', 'lib/libgdkglext-x11-1.0.%s' % SHLIB_EXT, | |||
| 'files': ['lib/gtkglext-1.0/include/gdkglext-config.h', 'lib/libgdkglext-x11-1.0.a', | |||
| 'lib/libgdkglext-x11-1.0.%s' % SHLIB_EXT, | |||
There was a problem hiding this comment.
keep the .a and this entry together on the same line?
| ('lib/python%s/site-packages/%s' % (pyver, eggname), 'lib64/python%s/site-packages/%s' % (pyver, eggname))], | ||
| 'dirs': [], | ||
| 'files': ['bin/gc3utils'], | ||
| 'dirs': [('lib/python%s/site-packages' % pyver, 'lib64/python%s/site-packages')], |
There was a problem hiding this comment.
@migueldiascosta missing 2nd pyver
|
Test report by @boegel |
|
Going in, thanks @migueldiascosta! |
(created using
eb --new-pr)