Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{phys}[intel/2017a] BerkeleyGW v1.2.0 #4399

Merged
merged 4 commits into from
May 8, 2017
Merged

{phys}[intel/2017a] BerkeleyGW v1.2.0 #4399

merged 4 commits into from
May 8, 2017

Conversation

migueldiascosta
Copy link
Member

(created using eb --new-pr)

@migueldiascosta
Copy link
Member Author

requires manual download after (free) registration

@boegel
Copy link
Member

boegel commented Mar 27, 2017

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2592.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/54b8dba5b192baff315ead27f83f9875 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 27, 2017

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2065.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/17a8ba38751c2c3985f32efadd29d6ef for a full test report.

@boegel
Copy link
Member

boegel commented Mar 27, 2017

@migueldiascosta did this work for you?

@migueldiascosta
Copy link
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.8, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.6.6
See https://gist.github.com/f52785d9f3217390b38392201d6e23df for a full test report.

@migueldiascosta
Copy link
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
nscc04 - Linux RHEL 6.8, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz, Python 2.7.12
See https://gist.github.com/e4bc0ace0912552f806ff5a510a0c5a5 for a full test report.

@migueldiascosta
Copy link
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-lin - Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2620 v2 @ 2.10GHz, Python 2.7.5
See https://gist.github.com/13ef0742138372196cd2e0d02d07fbdf for a full test report.

@migueldiascosta
Copy link
Member Author

https://gcc.gnu.org/gcc-4.8/porting_to.html

@boegel boegel modified the milestone: 3.2.0 Mar 28, 2017
boegel
boegel reviewed Mar 28, 2017
View reviewed changes
easybuild/easyconfigs/b/BerkeleyGW/BerkeleyGW-1.2.0-intel-2017a.eb Outdated

buildopts = 'all-flavors COMPFLAG=-DINTEL PARAFLAG="-DMPI -DOMP" DEBUGFLAG="" F90free="$MPIF90 -free" LINK="$MPIF90" '
buildopts += 'FOPTS="$FFLAGS -qopenmp" MOD_OPT="-module " C_PARAFLAG="$PARAFLAG" CC_COMP="$MPICXX" C_COMP="$MPICC" '
buildopts += 'FCPP="cpp -C -P -ffreestanding" C_LINK="$MPICXX" C_OPTS="$CFLAGS -qopenmp" MKLPATH="$MKLROOT" '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@migueldiascosta rather than hardcoding -qopenmp which is specific to Intel compilers, we should enable the openmp toolchain option, which will include -fopenmp in $CFLAGS & co

toolchainopts = {'usempi': True, 'openmp': True}

@boegel
Copy link
Member

boegel commented Mar 28, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2124.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/e39d3fea91fcc022f88e3f6ae3ba135d for a full test report.

boegel
boegel requested changes Mar 29, 2017
View reviewed changes
easybuild/easyconfigs/b/BerkeleyGW/BerkeleyGW-1.2.0-intel-2017a.eb Outdated
prebuildopts = 'cp config/generic.mpi.linux.mk arch.mk && '

buildopts = 'all-flavors COMPFLAG=-DINTEL PARAFLAG="-DMPI -DOMP" DEBUGFLAG="" F90free="$MPIF90 -free" LINK="$MPIF90" '
buildopts += 'FOPTS="$FFLAGS -qopenmp" MOD_OPT="-module " C_PARAFLAG="$PARAFLAG" CC_COMP="$MPICXX" C_COMP="$MPICC" '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@migueldiascosta you missed a spot, another -qopenmp here ;)

@boegel boegel modified the milestones: 3.2.0, 3.3.0 May 2, 2017
@boegel
Copy link
Member

boegel commented May 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2507.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ff0459eb0d92856e55b5ceb8da5f9c86 for a full test report.

@boegel
Copy link
Member

boegel commented May 8, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2109.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/7b7e00bd0047d08ec923ebcf272ff9d9 for a full test report.

@boegel boegel modified the milestones: 3.2.1, 3.3.0 May 8, 2017
@boegel
Copy link
Member

boegel commented May 8, 2017

lgtm

@boegel
Copy link
Member

boegel commented May 8, 2017

Going in, thanks @migueldiascosta!

@boegel boegel merged commit 92abf4c into easybuilders:develop May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@migueldiascosta @boegel