Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with configparser and backports namespace blocking inclusion of nbconvert with IPython #4504

Merged
merged 2 commits into from Apr 21, 2017
Merged

fix issue with configparser and backports namespace blocking inclusion of nbconvert with IPython #4504

merged 2 commits into from Apr 21, 2017

Conversation

boegel
Copy link
Member

@boegel boegel commented Apr 20, 2017 •
edited

fix for #3825

requires easybuilders/easybuild-framework#2194, since nbconvert 5.1.1 requires that use_pip is enabled

@boegel boegel added this to the 3.2.0 milestone Apr 20, 2017
@boegel
Copy link
Member Author

boegel commented Apr 20, 2017

@wpoely86 please review?

@boegel boegel mentioned this pull request Apr 20, 2017
Closed
wpoely86
wpoely86 approved these changes Apr 20, 2017
View reviewed changes
easybuild/easyconfigs/c/configparser/configparser-3.5.0-foss-2016a-Python-2.7.11.eb
patches = ['configparser-%(version)s_no-backports-namespace.patch']

dependencies = [('Python', '2.7.11')]
builddependencies = [('pip', '8.1.2', versionsuffix)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't we got one inside Python?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the one included in Python 2.7.11 is too old, pip 8.x is required for pip install --prefix

@boegel boegel mentioned this pull request Apr 20, 2017
Merged
@boegel
Copy link
Member Author

boegel commented Apr 20, 2017

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
node2151.delcatty.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fd4a38fdea1b5048c4feb9fd18e9c352 for a full test report.

@boegel
Copy link
Member Author

boegel commented Apr 20, 2017

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
node2523.golett.os - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/537695dcb083f059089faebaf13546bc for a full test report.

@boegel
Copy link
Member Author

boegel commented Apr 21, 2017

Thanks for the review @wpoely86!

@boegel boegel merged commit 13ea5c5 into easybuilders:develop Apr 21, 2017
@boegel boegel deleted the configparser_fix_backports_namespace branch April 21, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boegel @wpoely86