Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{chem,data.lib,devel}[intel/2017b] AmberMini-16.16.0, LZO-2.09, mpi4py-3.0.0, netcdf4-python-1.3.1, numexpr-2.6.4, ParmEd-2.7.3, PyTables-3.4.2, pandas-0.21.0, pymbar-3.0.3 #5476

Merged
merged 3 commits into from Dec 6, 2017

Conversation

tovrstra
Copy link
Contributor

@tovrstra tovrstra commented Dec 6, 2017

These are easyconfigs related to alchemical free energy calculations with OpenMM.

Full disclosure: I stole the patch file from /apps/gent/CO7/sandybridge/software/PyTables/3.4.2-intel-2017a-Python-3.6.1/easybuild/pyTables-3.4.2-fix-libs.patch.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -0,0 +1,12 @@
--- PyTables-3.4.2/setup.py.orig 2017-11-10 17:26:25.248733569 +0100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tovrstra This same patch is included in #5325, but with an extra comment on top, so different checksum.

Please steal it from there instead (and fix the checksum), to avoid conflicts if this gets merged first. ;-)

@boegel boegel added this to the next release milestone Dec 6, 2017
@boegel
Copy link
Member

boegel commented Dec 6, 2017

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (9 easyconfigs in this PR)
node2404.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/b5b10e2a44ab754b5de5d480ccf72e89 for a full test report.

@boegel
Copy link
Member

boegel commented Dec 6, 2017

Test report by @boegel
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in this PR)
node2029.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/94c38ce865dd42f1c0b272e5e69102d5 for a full test report.

patches = ['netcdf4-python-1.1.8-avoid-diskless-test.patch']
checksums = [
'a1674d281d54af9dd83e38f1be2dabed7de0f1bc8165adcd39c8dfddc4ec20b4', # v1.3.1rel.tar.gz
'a8b262fa201d55f59015e1bc14466c1d113f807543bc1e05a22481ab0d216d72', # netcdf4-python-1.1.8-avoid-diskless-test.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tovrstra Line too long, please reformat to the below to pass the style checks:

checksums = [
    'a1674d281d54af9dd83e38f1be2dabed7de0f1bc8165adcd39c8dfddc4ec20b4',  # v1.3.1rel.tar.gz
    # netcdf4-python-1.1.8-avoid-diskless-test.patch
    'a8b262fa201d55f59015e1bc14466c1d113f807543bc1e05a22481ab0d216d72',
]

@boegel
Copy link
Member

boegel commented Dec 6, 2017

Going in, thanks @tovrstra!

@boegel boegel merged commit e57b42a into easybuilders:develop Dec 6, 2017
@boegel boegel modified the milestones: next release, 3.5.0 Dec 6, 2017
@tovrstra
Copy link
Contributor Author

tovrstra commented Dec 6, 2017

It was a pleasure. :)

@tovrstra tovrstra deleted the severalconfigs branch December 6, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants