Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tkinter sanity check to matplotlib (foss toolchains) #5689

Merged

Conversation

schiotz
Copy link
Contributor

@schiotz schiotz commented Jan 21, 2018

(created using eb --new-pr)

@schiotz
Copy link
Contributor Author

schiotz commented Jan 21, 2018

I have added Tkinter sanity checks to matplotlib as discussed in PR #5658

@boegel I have only done it for foss toolchains 2016b and 2017b, as there is no Tk for foss-2017a and those are the only three toolchains I can test locally. I will do the same for newer Intel toolchains in a separate PR.

@schiotz
Copy link
Contributor Author

schiotz commented Jan 21, 2018

Test report by @schiotz
SUCCESS
Build succeeded for 10 out of 10 (6 easyconfigs in this PR)
thul.fysik.dtu.dk - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/996c1608249f952583bbfc214982d58d for a full test report.

@boegel boegel added this to the next release (3.5.2 or 3.6.0) milestone Jan 22, 2018
@boegel
Copy link
Member

boegel commented Jan 22, 2018

@schiotz Please make the same changes to the two matplotlib easyconfigs using foss/2017a, since otherwise it's a bit inconsistent, just add the required Tk easyconfig as well.

Not doing so for matplotlib easyconfigs that use a toolchain older than foss/2016b makes sense though.

@schiotz
Copy link
Contributor Author

schiotz commented Jan 24, 2018

@boegel I finally found time to add the configs for the foss/2017a toolchain.

@schiotz
Copy link
Contributor Author

schiotz commented Feb 22, 2018

@boegel Is there anything more I should do regarding this PR?

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 22, 2018

Sorry for not getting back to this earlier @schiotz, your last update drowned in my inbox...

I'll get this merged ASAP, and then issue a PR on top of this myself to make this consistent in the recent matplotlib easyconfigs that built with intel.

@boegel
Copy link
Member

boegel commented Feb 22, 2018

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in this PR)
node2428.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/61de737edab59ba049cd81978f04b727 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 22, 2018

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in this PR)
gligar03.gligar.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/00ca653ae753a3fa50ec39895c507910 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 22, 2018

Going in, thanks @schiotz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants