New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tkinter sanity check to matplotlib (foss toolchains) #5689
Add Tkinter sanity check to matplotlib (foss toolchains) #5689
Conversation
Test report by @schiotz |
@schiotz Please make the same changes to the two Not doing so for |
@boegel I finally found time to add the configs for the foss/2017a toolchain. |
@boegel Is there anything more I should do regarding this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sorry for not getting back to this earlier @schiotz, your last update drowned in my inbox... I'll get this merged ASAP, and then issue a PR on top of this myself to make this consistent in the recent |
Test report by @boegel |
Test report by @boegel |
Going in, thanks @schiotz! |
(created using
eb --new-pr
)