Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{math}[foss/2017b] FreeFem++ v3.58 #5918

Merged

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Feb 27, 2018

(created using eb --new-pr)

'files': ['bin/%s' % x for x in ['bamg', 'cvmsh2', 'ffglut', 'ffmedit']] +
['bin/ff-%s' % x for x in ['c++', 'get-dep', 'mpirun', 'pkg-download']] +
['bin/FreeFem++%s' % x for x in ['', '-mpi', '-nw']],
'dirs': ['share/freefem++/3.58/'] + ['lib/ff++/3.58/%s' % x for x in ['bin', 'etc', 'idp', 'include', 'lib']]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Please use the %(version)s template rather than hardcoding 3.58


# dependencies are heavily patched by FreeFem++, we therefore let it download and install them itself
prebuildopts = 'download/getall -a -o ScaLAPACK,ARPACK,freeYams,Gmm++,Hips,Ipopt,METIS,ParMETIS,MMG3D,mshmet,MUMPS,'
prebuildopts += 'NLopt,pARMS,PaStiX,Scotch,SuiteSparse,SuperLU_DIST,SuperLU,TetGen,PETSc,SLEPc,hpddm &&'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Do they patch all of these?

Can we download these via sources and feed them in somehow (so we control which versions are used)?

@boegel
Copy link
Member

boegel commented Jun 11, 2018

@smoors How shall we proceed with this? See also #6443?

@smoors
Copy link
Contributor Author

smoors commented Jun 11, 2018

@boegel Your suggestion to improve the installation method is certainly valid, but I currently have no time to look further into it. I think this easyconfig is still useful for users who want it to be as close as possible to what the developers intended.
I've updated the PR with the version template.

@boegel
Copy link
Member

boegel commented Jun 12, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2646.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/b2318a5f36151bec0ed0c5a2549985ff for a full test report.

@boegel
Copy link
Member

boegel commented Jun 12, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2010.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/e7c376504f166e8e6cf5dd3dfb7c65e5 for a full test report.

@boegel boegel added this to the 3.6.2 milestone Jun 12, 2018
@boegel
Copy link
Member

boegel commented Jun 12, 2018

Getting this to work without auto-downloading of dependencies is probably more work than makes sense, at least for now, so merging as is, thanks @smoors!

@boegel
Copy link
Member

boegel commented Jun 12, 2018

Going in, thanks @smoors!

@boegel boegel merged commit 3fa440e into easybuilders:develop Jun 12, 2018
@smoors smoors deleted the 20180227105731_new_pr_FreeFem++358 branch January 27, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants