Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't include (ancient version of) Time::HiRes as Perl extension, since it's a core Perl module #6225

Merged
merged 1 commit into from Apr 25, 2018

Conversation

boegel
Copy link
Member

@boegel boegel commented Apr 24, 2018

This reverts #5616 .

Including Time::HiRes as extension doesn't make sense, since it's a core Perl module (that is, it's always available).

Moreover, the Time::HiRes version that was included in #5616 is an ancient version, or some kind of customised fork of the official Time::HiRes.

Some installations are currently failing because of this:

  • BioPerl: "tv_interval" is not exported by the Time::HiRes module
  • proovread: "usleep" is not exported by the Time::HiRes module

This change was done for QUAST (cfr. #5610), but QUAST-4.6.0-foss-2016b-Python-3.5.2.eb builds just fine on top of Perl/5.24.0-foss-2016b that doesn't include Time::HiRes as an extension...

@boegel
Copy link
Member Author

boegel commented Apr 24, 2018

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
node2724.swalot.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/736cb28c94d7063a2197d3ea7809c1b8 for a full test report.

@boegel boegel requested a review from vanzod April 24, 2018 21:04
@boegel
Copy link
Member Author

boegel commented Apr 24, 2018

Test report by @boegel
SUCCESS
Build succeeded for 20 out of 20 (20 easyconfigs in this PR)
node2121.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a2f7d63f56a04020222ebc84ccafec05 for a full test report.

Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @boegel!

@boegel
Copy link
Member Author

boegel commented Apr 25, 2018

for completeness sake: these got included by accident, cfr. #5610 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants