Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{cae}[dummy/dummy] FDTD_Solutions v8.20.1731 #7088

Conversation

migueldiascosta
Copy link
Member

@migueldiascosta migueldiascosta commented Oct 30, 2018

(created using eb --new-pr)

requires easybuilders/easybuild-easyblocks#1307

@migueldiascosta
Copy link
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.7.14
See https://gist.github.com/d22b59cfa0437fa004771d8a5b33bb15 for a full test report.

@migueldiascosta
Copy link
Member Author

@akesandgren this comes packaged with mpich2 libraries, but would need impi or OpenMPI to be loaded if those are to be used, should I add separate easyconfig files with the respective dependencies? how have you been using it?

@akesandgren
Copy link
Contributor

We used dummy tc and didn't add any MPI stuff. But there are a couple of patches that would probably be useful. See #5502

And easybuilders/easybuild-easyblocks#1307 is also useful (still needs a review and merge)

@migueldiascosta
Copy link
Member Author

hm, I missed #5502, I'll have a look

(easybuilders/easybuild-easyblocks#1307 is precisely what this was meant to test :) )

@easybuilders easybuilders deleted a comment from boegelbot Oct 30, 2018
@boegel boegel added this to the 3.8.0 milestone Oct 30, 2018
@boegel boegel modified the milestones: 3.8.0, 3.8.1 Dec 14, 2018
@boegel boegel modified the milestones: 3.8.1, 3.x Jan 19, 2019
@migueldiascosta
Copy link
Member Author

added one patch from #5502, the other two don't seem to apply any more

@migueldiascosta
Copy link
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.7.14
See https://gist.github.com/28346923333374a06151f310d6df6f63 for a full test report.

@boegel
Copy link
Member

boegel commented May 8, 2019

@akesandgren Maybe also submit a test report for this (and then merge if it's good to go)?

@boegel boegel requested a review from akesandgren May 8, 2019 08:36
@akesandgren
Copy link
Contributor

We only have 8.16.982 so can't test this one.

@akesandgren
Copy link
Contributor

@migueldiascosta doesn't it still hardcode paths to /opt in all the scripts and the python script?

@migueldiascosta
Copy link
Member Author

@akesandgren their python script has been fixed. The bundled MPI is now mpich2/nemesis and it only ships mpiexec binaries and the libraries, no mpirun scripts. The fdtd-run-local.sh now uses this mpiexec.

For other MPI libraries, it seems we it is now needed to use their own launchers, hence the question I asked at the beginning of this PR about loading ipmi or OpenMPI.

There is indeed one additional hardcoded path that you fixed in your patch, the one in templates/fdtd-pbs-template.sh. Not only is it still hardcoded, it's hardcoded to a now non-existing path, I'll fix that.

@migueldiascosta
Copy link
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.7.14
See https://gist.github.com/e3a8e0c90f5e249920feebdb1b15312f for a full test report.

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @migueldiascosta!

@akesandgren akesandgren merged commit e90b0c6 into easybuilders:develop May 9, 2019
@boegel boegel modified the milestones: 3.x, next release (3.9.1) May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants