New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{cae}[dummy/dummy] FDTD_Solutions v8.20.1731 #7088
{cae}[dummy/dummy] FDTD_Solutions v8.20.1731 #7088
Conversation
Test report by @migueldiascosta |
@akesandgren this comes packaged with |
We used dummy tc and didn't add any MPI stuff. But there are a couple of patches that would probably be useful. See #5502 And easybuilders/easybuild-easyblocks#1307 is also useful (still needs a review and merge) |
hm, I missed #5502, I'll have a look (easybuilders/easybuild-easyblocks#1307 is precisely what this was meant to test :) ) |
added one patch from #5502, the other two don't seem to apply any more |
Test report by @migueldiascosta |
@akesandgren Maybe also submit a test report for this (and then merge if it's good to go)? |
We only have 8.16.982 so can't test this one. |
@migueldiascosta doesn't it still hardcode paths to /opt in all the scripts and the python script? |
@akesandgren their python script has been fixed. The bundled MPI is now For other MPI libraries, it seems we it is now needed to use their own launchers, hence the question I asked at the beginning of this PR about loading There is indeed one additional hardcoded path that you fixed in your patch, the one in |
Test report by @migueldiascosta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @migueldiascosta! |
(created using
eb --new-pr
)requires
easybuilders/easybuild-easyblocks#1307