Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{vis}[intel/2018b] Blender v2.79b, OpenImageIO v1.8.16, OpenEXR v2.3.0, ... #7127

Merged
merged 7 commits into from Nov 8, 2018
Merged

{vis}[intel/2018b] Blender v2.79b, OpenImageIO v1.8.16, OpenEXR v2.3.0, ... #7127

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d875ccb
adding easyconfigs: Blender-2.79b-intel-2018b-Python-3.6.6.eb, OpenIm…
Nov 6, 2018
4252957
remove suffix
Nov 6, 2018
fb5ecc4
Delete OpenEXR-2.3.0-intel-2018b-Python-%(pyver)s.eb
smoors Nov 6, 2018
14e3229
make suggested style change
Nov 7, 2018
1286c56
add Boost dep
Nov 7, 2018
b5043c1
unset OPENEXR_BUILD_PYTHON_LIBS
Nov 7, 2018
0d5ac0c
remove comment
Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions easybuild/easyconfigs/o/OpenEXR/OpenEXR-2.3.0-intel-2018b.eb
View file
Open in desktop
Expand Up @@ -15,6 +15,8 @@ checksums = ['8243b7de12b52239fe9235a6aeb4e35ead2247833e4fbc41541774b222717933']

builddependencies = [('CMake', '3.12.1')]

dependencies = [('Boost', '1.67.0')]
Copy link
Member

@ocaisa ocaisa Nov 7, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the error that required this dep was

boost Python is a required dependency when OPENEXR_BUILD_PYTHON_LIBS is set

so perhaps we should actually be unsetting OPENEXR_BUILD_PYTHON_LIBS or you should be including Python as a dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would indeed be a better solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors Why not leave OPENEXR_BUILD_PYTHON_LIBS enabled and include Boost.Python as a dep? Seems like minimal effort...

That would also require the customary versionsuffix of course (and including Python as a direct dep to ensure %(pyver)s template is resolved).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could try that, but Boost.Python is version 1.68.0 for 2018b (annoyingly), whereas OpenImageIO and Blender use Boost 1.67.0 (Blender recommends this version).
it works as it is now, and I prefer not to add Python as it is not needed.


sanity_check_paths = {
ocaisa marked this conversation as resolved.
Show resolved Hide resolved
'files': ['lib/lib%s-%%(version_major)s_%%(version_minor)s.%s' % (x, SHLIB_EXT) for x in
['Half', 'Iex', 'IexMath', 'IlmImf', 'IlmImfUtil', 'IlmThread', 'Imath']] +
Expand Down