Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bio}[dummy/dummy] KNIME v3.6.2 #7554

Merged
merged 2 commits into from Feb 19, 2019
Merged

{bio}[dummy/dummy] KNIME v3.6.2 #7554

merged 2 commits into from Feb 19, 2019

Conversation

HPC-UniOldenburg
Copy link
Contributor

(created using eb --new-pr)

boegel
boegel requested changes Feb 7, 2019
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HPC-UniOldenburg Thank you very much for your contribution!

Just a couple of small things to change, please let us know if you need any help with this.

--update-pr will come in useful, see https://easybuild.readthedocs.io/en/latest/Integration_with_GitHub.html#updating-existing-pull-requests-update-pr

easybuild/easyconfigs/k/KNIME/KNIME-3.6.2.eb Outdated Show resolved Hide resolved
easybuild/easyconfigs/k/KNIME/KNIME-3.6.2.eb Outdated Show resolved Hide resolved
@boegel boegel added the new label Feb 7, 2019
@boegel boegel added this to the 3.x milestone Feb 7, 2019
boegel
boegel previously requested changes Feb 7, 2019
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(requested changes)

@HPC-UniOldenburg
Copy link
Contributor Author

Dear @boegel ,
thank you very much for taking a look at my first PR.
The changes are done and updated but I'm always happy about any kind of feedback!

@vanzod
Copy link
Member

vanzod commented Feb 19, 2019

Test report by @vanzod
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
cermis - Linux debian 9.7, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/16ba70e341ee8877e7eccc893521be05 for a full test report.

@vanzod vanzod dismissed boegel’s stale review February 19, 2019 22:35

Implemented requested changes

@vanzod
Copy link
Member

vanzod commented Feb 19, 2019

Going in, thanks @HPC-UniOldenburg!

@vanzod vanzod merged commit 90dcbd1 into easybuilders:develop Feb 19, 2019
@boegel boegel modified the milestones: 3.x, next release (3.8.2) Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanzod vanzod vanzod approved these changes

@boegel boegel boegel left review comments

Assignees
No one assigned
Labels
new
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HPC-UniOldenburg @vanzod @boegel