don't use local variable 'pylibdir' in list comprehension in PyQt easyconfig, since that doesn't work in Python 3 #7848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing
PyQt-4.12.3-fosscuda-2018b-Python-2.7.15.eb
on top of Python 3 (using the4.x
branches) fails with:This issue is similar to the one we danced around with #7797.
The underlying issue is probably that list comprehensions have their own scope in Python 3, see also https://portingguide.readthedocs.io/en/latest/comprehensions.html .
Another way to fix this is to declare
pylibdir
asglobal
in the easyconfig, but I'd like to avoid that...