Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download correct Net-core tarball and add new easyconfig for Net-core 2.2.5 #8530

Merged
merged 1 commit into from Jul 4, 2019
Merged

download correct Net-core tarball and add new easyconfig for Net-core 2.2.5 #8530

merged 1 commit into from Jul 4, 2019

Conversation

pescobar
Copy link
Member

@pescobar pescobar commented Jul 3, 2019

I realized that the tarball to download is named dotnet-runtime and not aspnetcore-runtime

I have also added another easyconfig with the latest version

@pescobar pescobar mentioned this pull request Jul 3, 2019
Merged
@boegel boegel changed the title download proper net-core tarball and add new net-core easyconfig download proper Net-core tarball and add new easyconfig for Net-core 2.2.5 Jul 4, 2019
@boegel boegel changed the title download proper Net-core tarball and add new easyconfig for Net-core 2.2.5 download correct Net-core tarball and add new easyconfig for Net-core 2.2.5 Jul 4, 2019
@boegel
Copy link
Member

boegel commented Jul 4, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3102.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/6957c2ad7be59bcca915c8cb388738f2 for a full test report.

@boegel boegel added this to the next release (3.9.3) milestone Jul 4, 2019
@boegel
Copy link
Member

boegel commented Jul 4, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2633.swalot.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ff658db3bc8928f5eb1bf7ce0892e7ad for a full test report.

boegel
boegel approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jul 4, 2019

Going in, thanks @pescobar!

@boegel boegel merged commit 3ec4878 into easybuilders:develop Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix update
Projects
None yet
Milestone
3.9.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pescobar @boegel