Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch to Python 3.7.2 easyconfig to fix faulthandler segfault #8781

Merged
merged 3 commits into from Aug 22, 2019
Merged

add patch to Python 3.7.2 easyconfig to fix faulthandler segfault #8781

merged 3 commits into from Aug 22, 2019

Conversation

justbennet
Copy link
Contributor

This pull request addresses the Issue: Python 3.7.4 segfault during make test #8771

Adding patch file and patch line for Python-3.7.2 for GCCcore-8.2.0

See https://bugs.python.org/issue21131#msg349768 for discussion.

Upstream commit at Python source is at

python/cpython@1581d9c

@Micket Micket requested a review from boegel August 16, 2019 14:39
Micket
Micket previously approved these changes Aug 16, 2019
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (but i'd like a second opinion on the patch itself)

@boegel boegel added this to the next release (3.9.4?) milestone Aug 16, 2019
@boegel boegel added the bug fix label Aug 16, 2019
@@ -0,0 +1,33 @@
# This pull request addresses the Issue: Python 3.7.4 segfault during
# `make test` #8771
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justbennet I think it makes sense to replace the #8771 with the full URL to the easyconfigs issue, since this patch may start "traveling" at some point... (Don't forget to change the checksum for the patch too)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel It occurred to me as I was trying to make the comment more concise, also, that perhaps the patch file should be renamed, as it is applicable to all Python 3.7.x versions both forward and backward.

So, I added explicit URLs to the patch file, renamed the patch file to be more compatible for inclusion in subsequent Python 3.7 (and 3.8 when it comes along) easyconfigs, and regenerated the sha256 checksum (thanks for the reminder to do so).

Should this also be applied to these easyconfigs?

Python-3.7.0-foss-2018b.eb   Python-3.7.0-iomkl-2018b.eb
Python-3.7.0-intel-2018b.eb

I checked manually, and the faulthandler test also fails in 3.7.0, and the same patch will prevent the failure when using GCC 8.2.0. I tested that the patch works for Intel 18.0.5 when applied to the Python 3.7.0 source, also.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justbennet It makes sense to also apply this patch for Python 3.7.0, but should we do that in a separate PR (so we can merge this one, and include it in the EasyBuild v3.9.4 release which will go out really soon)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think getting this one done for the next release and then adding a second PR for the later release might be the better course.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boegel
Copy link
Member

boegel commented Aug 22, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3103.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/1d6363b8546ce4a27e6de3bec5028888 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 22, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2071.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a229e745364f013a63ac5da9e7dffd05 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 22, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2644.swalot.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/8de0c376bf080433006eb4a4ec8e0c3f for a full test report.

@boegel
Copy link
Member

boegel commented Aug 22, 2019

Going in, thanks @justbennet!

@boegel boegel merged commit f925c7d into easybuilders:develop Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants