Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Java/11 wrapper as dependency for ieeg-cli rather than depending on a specific Java version #8811

Merged
merged 1 commit into from Aug 22, 2019
Merged

use Java/11 wrapper as dependency for ieeg-cli rather than depending on a specific Java version #8811

merged 1 commit into from Aug 22, 2019

Conversation

boegel
Copy link
Member

@boegel boegel commented Aug 22, 2019

…

@boegel boegel added the change label Aug 22, 2019
@boegel boegel added this to the 3.9.4 milestone Aug 22, 2019
@boegel boegel mentioned this pull request Aug 22, 2019
Merged
@boegel boegel requested a review from smoors August 22, 2019 09:57
@boegel
Copy link
Member Author

boegel commented Aug 22, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3103.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/36a7ffde5fc8d6f5d17a41ca01d56834 for a full test report.

smoors
smoors approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Aug 22, 2019

Going in, thanks @boegel!

@smoors smoors merged commit a3aa328 into easybuilders:develop Aug 22, 2019
@boegel boegel deleted the ieeg_Java branch August 22, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoors smoors smoors approved these changes

Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
3.9.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boegel @smoors