Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using a name different from the git repo name during clone #3943

Closed
akesandgren opened this issue Jan 26, 2022 · 1 comment · Fixed by #3949
Closed

Support for using a name different from the git repo name during clone #3943

akesandgren opened this issue Jan 26, 2022 · 1 comment · Fixed by #3949

Comments

@akesandgren
Copy link
Contributor

I have a situation where the sources git_config need to create the clone in a name != the repo name. The main code uses a name that is different the the actual repo name.

I've made a temporary change locally to add this, the question is what to call that parameter?

My sources look like this

sources = [
    '%(version)s.tar.gz',
    {   
        'filename': 'avogenerators-20220126.tar.gz',
        'git_config': {
            'url': 'https://github.com/OpenChemistry',
            'repo_name': 'avogenerators',
            'commit': '582879c62b78b7c8a4e34c65a6027a4efa627b2f',
            'clone_name': 'avogadrogenerators',
        },
    },
]

The new one is of course "clone_name". Should we call it "clone_as" or something else?

@migueldiascosta
Copy link
Member

clone_into may be more consistent with git's terminology and documentation (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants