You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Commit 0e5ba5c858
introduced a check for string-type for versionsuffix, while None used to be an accepted value for versionsuffix. Our hooks replace many version suffixes with None.
The text was updated successfully, but these errors were encountered:
Interestingly every falsy value was accepted. So next to empty string and None also False or an empty list.
I don't see how anything but string and None make sense here
So might be ok to break a potential abuse and only allow None next to the string type.
However the dependency dictionary spec converts a versionsuffix unconditionally into a string:
So when there versionSuffix: None is used the result will be "None", so maybe we should keep this small breaking change as the error message is very clear and replacing the hook to use an empty string works always.
Commit 0e5ba5c858
introduced a check for string-type for
versionsuffix
, whileNone
used to be an accepted value forversionsuffix
. Our hooks replace many version suffixes withNone
.The text was updated successfully, but these errors were encountered: