Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide meaningful error message when failing sanity step #657

Closed
xaver42 opened this issue Jun 20, 2013 · 6 comments
Closed

provide meaningful error message when failing sanity step #657

xaver42 opened this issue Jun 20, 2013 · 6 comments

Comments

@xaver42
Copy link

xaver42 commented Jun 20, 2013

Trying to build this recipy:
https://gist.github.com/xaver42/5822924
the build fails with "Sanity check for YAMLSyck failed!"

Checking the logfile it takes some time to find the real error (disguised as a warning):
main.PerlModule WARNING Extension: YAMLSyck failed to install! (output: No module found for "YAML::Syck".
)

But even with this message I am puzzled, because the module is already installed at that time in easybuild's "software" directory.

So it would be good if:

  1. An error leading to the failure of the step is clearly marked as such in the log
  2. The framework reports where it looked for the files that were not found.
@boegel
Copy link
Member

boegel commented Jul 9, 2013

This is probably caused by the Perl module name you should specify when you want to use it, i.e. use YAML::Syck is probably not what you expect it to be.
So, it's not really a case of EB not finding a particular file, but rather Perl not being able to use the module with the name you've specified.
My guess would be that you need to adjust the following line in your easyconfig file to specify the correct Perl module name:

options = {'modulename': 'YAML::Syck'}

@xaver42 : That being said: you're right, the error message could be a lot clearer here. We'll look into that, issue a PR and ask you to take a look at it. But it's going to be post-v1.6 though.

@xaver42
Copy link
Author

xaver42 commented Jul 9, 2013

use YAML::Syck is the way to use that module, so this is not the problem (or did I misunderstand your comment?).

@boegel with PR you mean a PR for this module? Even if it dosn't build properly?

@boegel
Copy link
Member

boegel commented Jul 9, 2013

@xaver42: OK, then something else is going on, e.g. an incomplete Perl search path. We fixed something related to that in EB v1.6 (see easybuilders/easybuild-easyblocks#209).

With PR I mean a pull request for easybuild-framework that makes the error message clearer (and which isn't there yet right now).

@xaver42
Copy link
Author

xaver42 commented Jul 9, 2013

Sorry, I don't know enough about the internals of easybuild-framework to create a PR.

Edit: Ah, I think now I understand: You issue a PR, and I check whether this creates a more readable error message!?

@boegel
Copy link
Member

boegel commented Jul 9, 2013

@xaver42: Don't worry, we can look into that. I was not trying to convince you to issue a PR te resolve this (I know the framework can be quite daunting), I was just informing you that we're aware of the issue, and will look into it. We already made sanity check errors a lot more clear for non-extensions, we should do it for extensions as well.

@boegel
Copy link
Member

boegel commented Aug 2, 2013

@xaver42: Should be fixed by #672.

@boegel boegel closed this as completed Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants