-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path_matches #1163
Fix path_matches #1163
Conversation
Automatic reply from Jenkins: Can I test this? |
Jenkins: test this please |
Refer to this link for build results (access rights to CI server needed): |
would be great, but I'd love to see a dedicated unit test for this before we merged this in are you willing to give this a shot, @geimer? let me know if you need any help I should've asked you the same for #1164, so if you're up for it, add one for |
Ah, wait, #1164 isn't merged yet, so the unit tests for |
Jenkins: ok to test |
@geimer: looks great, thanks for tackling the unit test too! I'll merge this in if Jenkins is happy with it. |
Refer to this link for build results (access rights to CI server needed): |
Going in, thanks @geimer! |
The
path_matches
routine should ignore non-existing paths rather than fail hard...