move 'declare_namespace' statement last #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2860/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
boegel
added a commit
that referenced
this pull request
Mar 11, 2016
move 'declare_namespace' statement last
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a weird issue pop up that is hard to reproduce, where
lwas not defined anymore when it was being deleted.I think this is because the
delclare_namespacewas triggering thedelin another__init__.py, but in the same scope...This issue is not uncovered by the tests because it may only occur with an EasyBuild installation that was performed with
easy_install...This trivial change makes sure that the
delhappens before calling out todeclare_namespace, avoiding the issue all together.Same change was made in easyblocks companion PR to #1593, i.e. easybuilders/easybuild-easyblocks#827