only reset $MODULEPATH before loading a module if environment was reset #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 7, 2016
Closed
|
I've just checked it (I needed the bug fix for something, so timing was really convenient). It works now for me. |
|
Attached a debug log for those interested. ncurses was previously picked up from the wrong level ( |
|
@damianam Thanks for the confirmation! I'll see if this needs a test before it can be merged in... |
…n a module hierarchy
|
Test added, Travis approves, going in, thanks for reporting this @damianam and for verifying the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1787, alternative for #1792
Always redefining
$MODULEPATHaccording toself.mod_pathsfor everyloadis wrong, since the$MODULEPATHmay have been tweaked by previous loads with a module hierarchy.Besides, it's fairly expensive to do so as well (lots of unnecessary
module usecommands...).