update easybuild from command line #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,6 +272,10 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None): | |||
| search_easyconfigs(search_query, short=options.search_short, filename_only=options.search_filename, | |||
| terse=options.terse) | |||
|
|
|||
| if options.update: | |||
| eb_file = find_easybuild_eb() | |||
| orig_paths.append(eb_file) | |||
There was a problem hiding this comment.
I would try and make sure that only EasyBuild is installed, and throw an error if other easyconfigs are installed at the same time?
| @@ -1088,3 +1087,26 @@ def validate_github_token(token, github_user): | |||
| _log.info("GitHub token can be used for authenticated GitHub access, validation passed") | |||
|
|
|||
| return sanity_check and token_test | |||
|
|
|||
|
|
|||
| def find_easybuild_eb(): | |||
There was a problem hiding this comment.
@Caylo please add a unit test for this (just check whether it returns a path an existing easyconfig for EasyBuild)
There was a problem hiding this comment.
also, rename to find_easybuild_easyconfig?
|
@Caylo needs a sync with |
| for eb_file in files: | ||
| txt = read_file(os.path.join(eb_parent_path, eb_file)) | ||
| for line in txt.split('\n'): | ||
| if re.search(r'^version =', line): |
There was a problem hiding this comment.
use \s* rather than hardcoding the space before the =
| version = scope['version'] | ||
| file_versions.append((LooseVersion(version), eb_file)) | ||
|
|
||
| fn = sorted(file_versions)[-1][1] |
There was a problem hiding this comment.
@Caylo let's throw a proper error here if file_versions is empty...
|
going in, thanks @Caylo! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use:
eb --install-latest-eb-release