clarify unstable/closed PR warning message #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
reviewed
Feb 23, 2017
easybuild/tools/github.py
Outdated
| @@ -382,7 +382,8 @@ def fetch_easyconfigs_from_pr(pr, path=None, github_user=None): | |||
|
|
|||
| if not(pr_data['merged']): | |||
| if not stable or closed: | |||
| print "\n*** WARNING: Using easyconfigs from unstable/closed PR #%s ***\n" % pr | |||
| state_msg = "unstable (failed tests or merge conflict)" if not stable else "closed (but not merged)" | |||
There was a problem hiding this comment.
I think pending tests also result in 'unstable' state?
There was a problem hiding this comment.
sorry, right (that was the original scenario...)
can we distinguish between pending and failed?
There was a problem hiding this comment.
Hmm, we may be able to, but the GitHub API documentation isn't very clear on that...
|
lgtm |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.