Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix templating of values in list_software function #2591

Merged
merged 1 commit into from Sep 25, 2018
Merged

fix templating of values in list_software function #2591

merged 1 commit into from Sep 25, 2018

Conversation

boegel
Copy link
Member

@boegel boegel commented Sep 25, 2018

fix for problem reported in easybuilders/easybuild#446

@boegel boegel added the bug fix label Sep 25, 2018
@boegel boegel added this to the 3.7.1 milestone Sep 25, 2018
@boegel
Copy link
Member Author

boegel commented Sep 25, 2018

There's a test for list_software already, but we didn't have any templates in the easyconfigs used for the test. That is the case now, and the test_list_software fails without the fix with the modified test easyconfigs.

@boegel boegel requested a review from vanzod September 25, 2018 19:36
@boegel boegel mentioned this pull request Sep 25, 2018
Closed
@vanzod
Copy link
Member

vanzod commented Sep 25, 2018

Tested and ok

@vanzod vanzod merged commit fd58fa8 into easybuilders:develop Sep 25, 2018
@boegel boegel deleted the fix_list_software_templating branch September 26, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanzod vanzod vanzod approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
3.7.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boegel @vanzod