Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed easyconfig.update to be able to specify not to allow duplicate values #2657

Merged
merged 7 commits into from Nov 14, 2018
Merged

changed easyconfig.update to be able to specify not to allow duplicate values #2657

merged 7 commits into from Nov 14, 2018

Conversation

mboisson
Copy link
Contributor

@mboisson mboisson commented Nov 12, 2018 •
edited

@mboisson mboisson mentioned this pull request Nov 12, 2018
Merged
boegel
boegel requested changes Nov 13, 2018
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to add support for this, but it does require a test (and a fix, see other comment) before it can go in...

easybuild/framework/easyconfig/easyconfig.py Outdated Show resolved Hide resolved
@boegel boegel added this to the 3.8.0 milestone Nov 13, 2018
houndci-bot
houndci-bot reviewed Nov 14, 2018
View reviewed changes
test/framework/easyconfig.py Outdated Show resolved Hide resolved
test/framework/easyconfig.py Outdated Show resolved Hide resolved
@mboisson
Copy link
Contributor Author

Tests included. Fixed the list problem.

@mboisson
Copy link
Contributor Author

Mmmm, @boegel, am I noticing boegelbot acting stupid ? I don't understand the error log.

@boegel
Copy link
Member

boegel commented Nov 14, 2018

@mboisson No, it's correctly reporting a failing test. Try running the failing test locally with python -O -m test.framework.suite test_update.

@easybuilders easybuilders deleted a comment from boegelbot Nov 14, 2018
@mboisson
Copy link
Contributor Author

Ok, seems the tests all passed. Ready for another review @boegel

@easybuilders easybuilders deleted a comment from boegelbot Nov 14, 2018
@boegel
Copy link
Member

boegel commented Nov 14, 2018

lgtm, thanks @mboisson!

@boegel boegel merged commit c2ae926 into easybuilders:develop Nov 14, 2018
@mboisson mboisson deleted the update_without_dup branch May 6, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mboisson @boegel @houndci-bot