Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort available version list when selecting/generating easyconfig #2732

Merged
merged 8 commits into from
Apr 8, 2019
Merged

Sort available version list when selecting/generating easyconfig #2732

merged 8 commits into from
Apr 8, 2019

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Jan 21, 2019

Fix for #2731

@ocaisa ocaisa mentioned this pull request Jan 21, 2019
Open
@ocaisa ocaisa added the bug fix label Jan 21, 2019
@easybuilders easybuilders deleted a comment from boegelbot Jan 24, 2019
@ocaisa ocaisa requested a review from boegel January 24, 2019 12:50
@boegel boegel added this to the next release (3.8.2) milestone Feb 23, 2019
@damianam
Copy link
Member

This lgtm. But I haven't tested it. @ocaisa, @jose-d can you confirm that this change indeed fixes it?

@boegel boegel mentioned this pull request Apr 8, 2019
Merged
@boegel
Copy link
Member

boegel commented Apr 8, 2019

I've reproduced the bug being fixed here in the tests (and fixed another issue in pick_version along the way), please take a look at these additional changes @ocaisa: ocaisa#43

Merge pull request #43 from boegel/pick_version_bugfix
2cda83a 
add tests to capture fixed bugs in pick_version and --software (+ fix one more bug)
@boegel
Copy link
Member

boegel commented Apr 8, 2019

Going in, thanks for figuring out the fix @ocaisa!

@boegel boegel merged commit 5713368 into easybuilders:develop Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocaisa @damianam @boegel @houndci-bot