Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix running of 'toy_build' test suite with Python 3 #2785

Merged
merged 3 commits into from Feb 24, 2019
Merged

fix running of 'toy_build' test suite with Python 3 #2785

merged 3 commits into from Feb 24, 2019

Conversation

boegel
Copy link
Member

@boegel boegel commented Feb 22, 2019

No description provided.

@boegel boegel added the python3 Python 3 compatibility label Feb 22, 2019
@boegel boegel added this to the 4.0 milestone Feb 22, 2019
bartoldeman
bartoldeman approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel clarified that the default hashing works for Python 2 but not Python 3, so better to be explicit.

Approved then.

@easybuilders easybuilders deleted a comment from boegelbot Feb 23, 2019
@wpoely86 wpoely86 merged commit 24c0ea2 into easybuilders:4.x Feb 24, 2019
@boegel boegel deleted the py3_toy_build branch February 24, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpoely86 wpoely86 wpoely86 approved these changes

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees
No one assigned
Labels
python3 Python 3 compatibility
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boegel @wpoely86 @bartoldeman