New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate support for using Lmod 6.x #3077
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…testing with Python 2.7 over 2.6 (+ cleanup)
…eprecation warnings breaking tests when testing with Lmod 6.x
wpoely86
reviewed
Nov 12, 2019
wpoely86
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last EasyBuild user survey (conducted in Dec 2018) indicated that about 25% of the EasyBuild community was using Lmod 6 at the time. The most recent release of Lmod 6.x was in November 2016, so it's fair to assume that most people have upgraded to Lmod 7 or 8 by now.
We won't actively break support for Lmod 6 for now, but we need to trim down on the test configurations we're using in Travis CI & GitHub Actions to avoid waiting forever on test results.
With this change included, we will:
If desired, this warning can be avoided by configuring EasyBuild to skip the modules tool version check via
--disable-modules-tool-version-check
or by setting$EASYBUILD_DISABLE_MODULES_TOOL_VERSION_CHECK=1
(which is, for obvious reasons, not recommended).In addition, I've updated some of the modules tool log messages to clearly mention which modules tool is being used (see the
NAME
class variable that was set for each type of modules tool).