Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shebang even if first line doesn't start with '#!' #3183

Merged
merged 2 commits into from Feb 7, 2020
Merged

Fix shebang even if first line doesn't start with '#!' #3183

merged 2 commits into from Feb 7, 2020

Conversation

Darkless012
Copy link
Contributor

fixes #3179

@boegel boegel changed the title Fix shebang even if first line doesn't start with '#!'. (fixes #3179) Fix shebang even if first line doesn't start with '#!' Feb 1, 2020
boegel
boegel requested changes Feb 1, 2020
View reviewed changes
easybuild/framework/easyblock.py Outdated Show resolved Hide resolved
test/framework/toy_build.py Outdated Show resolved Hide resolved
@boegel boegel added this to the next release (4.1.2?) milestone Feb 1, 2020
@boegel boegel added the bug fix label Feb 1, 2020
@boegel boegel merged commit c54ca63 into easybuilders:develop Feb 7, 2020
@boegel boegel mentioned this pull request Feb 12, 2020
Merged
@boegel boegel mentioned this pull request Feb 20, 2020
Closed
boegel added a commit to boegel/easybuild-framework that referenced this pull request Feb 20, 2020
@boegel
don't add shebang to binary files (fixes easybuilders#3207, bug intro…
40a820e 
…duced in easybuilders#3183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesandgren akesandgren akesandgren left review comments

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Allow injecting shebang (now it only replaces - eg. touching files starting with '#!')
3 participants
@Darkless012 @akesandgren @boegel