-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also dump environment to reprod directory #3374
Conversation
Urgh, this triggers new logging which is breaking some tests that don't expect it. |
@ocaisa So you should fix up those tests then? |
@boegel I need some advice on this one, placing the env dump in the reprod dir saves me from having to do any bookkeeping but because it creates a nested easyblock instance there is a bit of a logging mess that is kicking errors in the tests |
…olved correctly) + fix comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ocaisa The env script is dumped too early, the build environment isn't set up yet when you create it:
$ cat $EASYBUILD_PREFIX/software/bzip2/1.0.8-GCCcore-9.3.0/easybuild/reprod/*env
#!/bin/bash
# script to set up build environment as defined by EasyBuild v4.2.2.dev0 for bzip2-1.0.8-GCCcore-9.3.0.eb
# usage: source bzip2-1.0.8-GCCcore-9.3.0.env
# toolchain & dependency modules
# (no modules loaded)
# build environment
# (no build environment defined)
@boegel I switched it to be done after the easyblock has been used and it seems to work. I haven't capture that in the tests though yet. This is not foolproof I suspect since it doesn't handle multi-deps or iterating builds |
… statements) Include Extension as an easyblock that should not be dumped to the reprod dir (since it is part of the framework)
@boegel I've added an additonal test that at least captures the module load for a dependency. Is it possible to trigger a build environment variable in the tests? I've also addressed the comment you made in #3375 (comment) |
@ocaisa What do you mean by "build environment variable"? To change the EasyBuild configuration used in a test, you can use |
Hard to remember, but I think I was talking about populating the lines
such as |
@boegel I'm kicking the tyres on this because it is actually really useful to have for EESSI, for example if someone wants build their own custom version of a package (I'm thinking about application maintainers using it in CI) |
I think it works fine, there is potentially an issue with multideps but we don't really have those any more. Example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going in, thanks @ocaisa! |
fixes #2111, related to #2284 (but doesn't really fixes it, according to @boegel)