add support for --accept-eula configuration option + 'accept_eula' easyconfig parameter #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… add generic support to check whether EULA is accepted via EasyBlock.check_accepted_eula() method
akesandgren
reviewed
Dec 24, 2020
|
Going in, thanks @boegel! |
1 task
|
|
||
| error_lines.extend([ | ||
| "You should either:", | ||
| "- add --accept-eula-for=%(name)s to the 'eb' command;", |
There was a problem hiding this comment.
@boegel either this should say --accept-eula= instead of --accept-eula-for=, no?
There was a problem hiding this comment.
Yes, you're right, I renamed the option to --accept-eula while working on it...
This was referenced Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will come in useful for software like AOCC and Intel's oneAPI that require accepting an End User License Agreement (EULA) on installation...