Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HierarchicalMNS for Intel OneAPI compilers #3653

Merged
merged 2 commits into from Apr 15, 2021
Merged

Update HierarchicalMNS for Intel OneAPI compilers #3653

merged 2 commits into from Apr 15, 2021

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Apr 15, 2021

No description provided.

ocaisa
ocaisa commented Apr 15, 2021
View reviewed changes
easybuild/tools/module_naming_scheme/hierarchical_mns.py Outdated
# required for use of ClangGCC toolchain
'Clang,GCC': ('Clang-GCC', '%(Clang)s-%(GCC)s'),
# required for use of gcccuda toolchain, and for CUDA installed with GCC toolchain
'CUDA,GCC': ('GCC-CUDA', '%(GCC)s-%(CUDA)s'),
# required for use of iccifortcuda toolchain
'CUDA,icc,ifort': ('intel-CUDA', '%(icc)s-%(CUDA)s'),
'CUDA,iccifort': ('intel-CUDA', '%(iccifort)s-%(CUDA)s'),
'CUDA,intel-compilers': ('intel-CUDA', '%(intel-compilers)s-%(CUDA)s'), # OneAPI compilers
Copy link
Member Author

@ocaisa ocaisa Apr 15, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove this since we are about to unify iccifort and iccifortcuda (so I have no toolchain to test this on, and we don't plan on having one).

@ocaisa
Copy link
Member Author

ocaisa commented Apr 15, 2021 •
edited

I tested this locally:

alanc@~$ eb --module-naming-scheme=HierarchicalMNS intel-compilers-2021.1.2.eb -x | grep MODULEPATH
    prepend_path("MODULEPATH", "/home/alanc/.local/easybuild/modules/all/Compiler/intel-compilers/2021.1.2")
alanc@~$ eb --include-module-naming-schemes=hierarchical_mns.py --module-naming-scheme=HierarchicalMNS intel-compilers-2021.1.2.eb -x | grep MODULEPATH
    prepend_path("MODULEPATH", "/home/alanc/.local/easybuild/modules/all/Compiler/intel/2021.1.2")

@ocaisa
Copy link
Member Author

ocaisa commented Apr 15, 2021

@boegel I think we are hitting API limits on GitHub or something. I've rerun these tests twice now and which ones fail is a moving target but seems to be related to GitHub:

easybuild.tools.build_log.EasyBuildError: 'Failed to get data for PR #1967 from easybuilders/easybuild-easyblocks (HTTP Error 403: Forbidden)\nPlease check PR #, account and repo.'

@Micket Micket added this to the next release (4.3.5?) milestone Apr 15, 2021
Micket
Micket approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 0055110 into develop Apr 15, 2021
@boegel boegel changed the title Update HMNS for Intel OneAPI compilers Update HierarchicalMNS for Intel OneAPI compilers Apr 17, 2021
@boegel boegel deleted the ocaisa-patch-1-1 branch April 17, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ocaisa @Micket